You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2023/09/07 01:12:05 UTC

[GitHub] [hudi] yihua opened a new pull request, #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

yihua opened a new pull request, #9634:
URL: https://github.com/apache/hudi/pull/9634

   ### Change Logs
   
   _Describe context and summary for this change. Highlight if any code was copied._
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9634:
URL: https://github.com/apache/hudi/pull/9634#issuecomment-1715068082

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19688",
       "triggerID" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "183dc4e2236a15571667440be3535b323f850865",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "183dc4e2236a15571667440be3535b323f850865",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac411efbc25b4fe1b11d0238ce45d77845b98cd8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19692",
       "triggerID" : "ac411efbc25b4fe1b11d0238ce45d77845b98cd8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75b920702d242e74d654a52858a3fe112caa21e8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19833",
       "triggerID" : "75b920702d242e74d654a52858a3fe112caa21e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 183dc4e2236a15571667440be3535b323f850865 UNKNOWN
   * ac411efbc25b4fe1b11d0238ce45d77845b98cd8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19692) 
   * 75b920702d242e74d654a52858a3fe112caa21e8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19833) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9634:
URL: https://github.com/apache/hudi/pull/9634#issuecomment-1715280052

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19688",
       "triggerID" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "183dc4e2236a15571667440be3535b323f850865",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "183dc4e2236a15571667440be3535b323f850865",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac411efbc25b4fe1b11d0238ce45d77845b98cd8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19692",
       "triggerID" : "ac411efbc25b4fe1b11d0238ce45d77845b98cd8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75b920702d242e74d654a52858a3fe112caa21e8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19833",
       "triggerID" : "75b920702d242e74d654a52858a3fe112caa21e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 183dc4e2236a15571667440be3535b323f850865 UNKNOWN
   * 75b920702d242e74d654a52858a3fe112caa21e8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19833) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9634:
URL: https://github.com/apache/hudi/pull/9634#issuecomment-1715005849

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19688",
       "triggerID" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "183dc4e2236a15571667440be3535b323f850865",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "183dc4e2236a15571667440be3535b323f850865",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac411efbc25b4fe1b11d0238ce45d77845b98cd8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19692",
       "triggerID" : "ac411efbc25b4fe1b11d0238ce45d77845b98cd8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "75b920702d242e74d654a52858a3fe112caa21e8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "75b920702d242e74d654a52858a3fe112caa21e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 183dc4e2236a15571667440be3535b323f850865 UNKNOWN
   * ac411efbc25b4fe1b11d0238ce45d77845b98cd8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19692) 
   * 75b920702d242e74d654a52858a3fe112caa21e8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9634:
URL: https://github.com/apache/hudi/pull/9634#issuecomment-1709414211

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19688",
       "triggerID" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "183dc4e2236a15571667440be3535b323f850865",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "183dc4e2236a15571667440be3535b323f850865",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac411efbc25b4fe1b11d0238ce45d77845b98cd8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19692",
       "triggerID" : "ac411efbc25b4fe1b11d0238ce45d77845b98cd8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ca596290a9962ce131ad38c615d42604579ad36d Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19688) 
   * 183dc4e2236a15571667440be3535b323f850865 UNKNOWN
   * ac411efbc25b4fe1b11d0238ce45d77845b98cd8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19692) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9634:
URL: https://github.com/apache/hudi/pull/9634#issuecomment-1715577797

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "75b920702d242e74d654a52858a3fe112caa21e8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19833",
       "triggerID" : "75b920702d242e74d654a52858a3fe112caa21e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 75b920702d242e74d654a52858a3fe112caa21e8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19833) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9634:
URL: https://github.com/apache/hudi/pull/9634#issuecomment-1709383233

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19688",
       "triggerID" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "183dc4e2236a15571667440be3535b323f850865",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "183dc4e2236a15571667440be3535b323f850865",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac411efbc25b4fe1b11d0238ce45d77845b98cd8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac411efbc25b4fe1b11d0238ce45d77845b98cd8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ca596290a9962ce131ad38c615d42604579ad36d Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19688) 
   * 183dc4e2236a15571667440be3535b323f850865 UNKNOWN
   * ac411efbc25b4fe1b11d0238ce45d77845b98cd8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9634:
URL: https://github.com/apache/hudi/pull/9634#issuecomment-1709893339

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19688",
       "triggerID" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "183dc4e2236a15571667440be3535b323f850865",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "183dc4e2236a15571667440be3535b323f850865",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac411efbc25b4fe1b11d0238ce45d77845b98cd8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19692",
       "triggerID" : "ac411efbc25b4fe1b11d0238ce45d77845b98cd8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 183dc4e2236a15571667440be3535b323f850865 UNKNOWN
   * ac411efbc25b4fe1b11d0238ce45d77845b98cd8 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19692) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] codope commented on a diff in pull request #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #9634:
URL: https://github.com/apache/hudi/pull/9634#discussion_r1322378782


##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataParquetWriteSupport.java:
##########
@@ -71,7 +70,7 @@ public HoodieBloomFilterRowDataWriteSupport(BloomFilter bloomFilter) {
 
     @Override
     protected byte[] getUTF8Bytes(String key) {
-      return key.getBytes(StandardCharsets.UTF_8);
+      return getUTF8Bytes(key);

Review Comment:
   Need to import `StringUtils.getUTF8Bytes` otherwise it's recursive. i'll push a fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9634:
URL: https://github.com/apache/hudi/pull/9634#issuecomment-1709335387

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19688",
       "triggerID" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ca596290a9962ce131ad38c615d42604579ad36d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19688) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9634:
URL: https://github.com/apache/hudi/pull/9634#issuecomment-1709377606

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19688",
       "triggerID" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "183dc4e2236a15571667440be3535b323f850865",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "183dc4e2236a15571667440be3535b323f850865",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ca596290a9962ce131ad38c615d42604579ad36d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19688) 
   * 183dc4e2236a15571667440be3535b323f850865 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9634:
URL: https://github.com/apache/hudi/pull/9634#issuecomment-1709330058

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ca596290a9962ce131ad38c615d42604579ad36d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ca596290a9962ce131ad38c615d42604579ad36d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] yihua commented on pull request #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #9634:
URL: https://github.com/apache/hudi/pull/9634#issuecomment-1716543295

   > So this is a breaking change for Windows? Any path for users to safely migrate?
   
   I've updated the PR description.  We don't intend to make these backwards compatible for Windows which can be broken because of different default charset.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] codope merged pull request #9634: [HUDI-6825] Use UTF_8 to encode String to byte array in all places

Posted by "codope (via GitHub)" <gi...@apache.org>.
codope merged PR #9634:
URL: https://github.com/apache/hudi/pull/9634


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org