[GitHub] williaster commented on a change in pull request #3771: DECKGL integration - Phase 1

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #3771: DECKGL integration - Phase 1
URL: https://github.com/apache/incubator-superset/pull/3771#discussion_r150320385
 
 

 ##########
 File path: superset/assets/javascripts/explore/components/controls/FixedOrMetricControl.jsx
 ##########
 @@ -0,0 +1,124 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import { Label, Popover, OverlayTrigger } from 'react-bootstrap';
+
+import controls from '../../stores/controls';
+import TextControl from './TextControl';
+import SelectControl from './SelectControl';
+import ControlHeader from '../ControlHeader';
+import PopoverSection from '../../../components/PopoverSection';
+
+const controlTypes = {
+  fixed: 'fix',
+  metric: 'metric',
+};
+
+const propTypes = {
+  onChange: PropTypes.func,
+  value: PropTypes.object,
+  isFloat: PropTypes.bool,
+  datasource: PropTypes.object,
+  default: PropTypes.object,
 
 Review comment:
   should this be a shape?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services