You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2024/02/26 01:37:11 UTC
[PR] [WIP][SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
itholic opened a new pull request, #45244:
URL: https://github.com/apache/spark/pull/45244
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)`
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To improve error usability
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No API changes, but the user-facing error message will be improved
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Added UTs.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #45244:
URL: https://github.com/apache/spark/pull/45244#issuecomment-1974134659
Thanks for the review, @MaxGekk !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #45244:
URL: https://github.com/apache/spark/pull/45244#discussion_r1503547976
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1272,6 +1278,12 @@
],
"sqlState" : "42710"
},
+ "FIELD_INDEX_ON_ROW_WITHOUT_SCHEMA" : {
+ "message" : [
+ "fieldIndex on a Row without schema is undefined."
+ ],
+ "sqlState" : "42000"
Review Comment:
Sounds good. I think we can use `42601` - A character, token, or clause is invalid or missing -
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #45244:
URL: https://github.com/apache/spark/pull/45244#issuecomment-1965685388
Thanks, @MaxGekk for the review! Just adjusted comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #45244:
URL: https://github.com/apache/spark/pull/45244#discussion_r1506184659
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1272,6 +1272,12 @@
],
"sqlState" : "42710"
},
+ "FIELD_INDEX_ON_ROW_WITHOUT_SCHEMA" : {
Review Comment:
Could you create a sub-class of `UNSUPPORTED_CALL` like:
```
UNSUPPORTED_CALL.FIELD_INDEX
```
with simple explanation like `The row shall have a schema to get an index of the field <fieldName>.`
##########
sql/api/src/main/scala/org/apache/spark/sql/errors/ExecutionErrors.scala:
##########
@@ -127,13 +127,10 @@ private[sql] trait ExecutionErrors extends DataTypeErrorsBase {
}
def cannotParseStringAsDataTypeError(pattern: String, value: String, dataType: DataType)
- : SparkRuntimeException = {
- new SparkRuntimeException(
- errorClass = "_LEGACY_ERROR_TEMP_2134",
- messageParameters = Map(
- "value" -> toSQLValue(value),
- "pattern" -> toSQLValue(pattern),
- "dataType" -> dataType.toString))
+ : Throwable = {
+ SparkException.internalError(
+ s"Cannot parse field value ${toSQLValue(value)} for pattern ${toSQLValue(pattern)} " +
+ s"as target spark data type [${dataType.toString}].")
Review Comment:
```suggestion
s"as the target spark data type ${toSQLType(dataType)}.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #45244:
URL: https://github.com/apache/spark/pull/45244#discussion_r1507049200
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1272,6 +1272,12 @@
],
"sqlState" : "42710"
},
+ "FIELD_INDEX_ON_ROW_WITHOUT_SCHEMA" : {
Review Comment:
Sounds good. Just applied the comment. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #45244:
URL: https://github.com/apache/spark/pull/45244#discussion_r1503550776
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -298,6 +298,12 @@
],
"sqlState" : "22018"
},
+ "CANNOT_PARSE_STRING_AS_DATATYPE" : {
Review Comment:
According to https://github.com/apache/spark/pull/45244/files#r1503550041, let me just turn this into an internal error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #45244:
URL: https://github.com/apache/spark/pull/45244#issuecomment-1972461373
Hmm... `org.apache.spark.sql.catalyst.ShuffleSpecSuite` and `org.apache.spark.sql.connect.planner.SparkConnectProtoSuite` keep failing, but I think they don't seem to be related to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #45244:
URL: https://github.com/apache/spark/pull/45244#discussion_r1507171237
##########
sql/api/src/main/scala/org/apache/spark/sql/errors/DataTypeErrors.scala:
##########
@@ -261,8 +261,14 @@ private[sql] object DataTypeErrors extends DataTypeErrorsBase {
messageParameters = Map("raw" -> s"'$raw'"))
}
- def fieldIndexOnRowWithoutSchemaError(): SparkUnsupportedOperationException = {
- new SparkUnsupportedOperationException("_LEGACY_ERROR_TEMP_2231")
+ def fieldIndexOnRowWithoutSchemaError(fieldName: String): SparkUnsupportedOperationException = {
+ new SparkUnsupportedOperationException(
+ errorClass = "UNSUPPORTED_CALL.FIELD_INDEX",
+ messageParameters = Map(
+ "methodName" -> "fieldIndex",
+ "className" -> "Row",
+ "fieldName" -> fieldName)
Review Comment:
Wrap it by `toSQLId`, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #45244:
URL: https://github.com/apache/spark/pull/45244#discussion_r1503550041
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TimestampFormatterSuite.scala:
##########
@@ -502,4 +504,25 @@ class TimestampFormatterSuite extends DatetimeFormatterSuite {
assert(formatter.parseOptional("9999-12-31 23:59:59.999").isEmpty)
assert(formatter.parseWithoutTimeZoneOptional("9999-12-31 23:59:59.999", true).isEmpty)
}
+
+ test("fail to parse string as TimestampNTZ with invalid format") {
+ val zoneId = ZoneId.systemDefault()
+ val locale = Locale.getDefault()
+ val formatter = new DefaultTimestampFormatter(
+ zoneId, locale, LENIENT_SIMPLE_DATE_FORMAT, isParsing = true)
+
+ val invalidTimestampStr = "2021-13-01T25:61:61"
+
+ checkError(
+ exception = intercept[SparkRuntimeException] {
+ formatter.parseWithoutTimeZone(invalidTimestampStr, allowTimeZone = false)
Review Comment:
I just realized the comment from the source code below:
```
* The formatter for timestamps which doesn't require users to specify a pattern. While formatting,
* it uses the default pattern [[TimestampFormatter.defaultPattern()]]. In parsing, it follows
* the CAST logic in conversion of strings to Catalyst's TimestampType.
```
so I suspect that this cannot be reproduced from user space, so we should mark it as an internal error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #45244:
URL: https://github.com/apache/spark/pull/45244#issuecomment-1963619230
@MaxGekk Could you review this when you find some time? They are currently the most frequent top 2 legacy error classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #45244:
URL: https://github.com/apache/spark/pull/45244#discussion_r1502808003
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TimestampFormatterSuite.scala:
##########
@@ -502,4 +504,25 @@ class TimestampFormatterSuite extends DatetimeFormatterSuite {
assert(formatter.parseOptional("9999-12-31 23:59:59.999").isEmpty)
assert(formatter.parseWithoutTimeZoneOptional("9999-12-31 23:59:59.999", true).isEmpty)
}
+
+ test("fail to parse string as TimestampNTZ with invalid format") {
+ val zoneId = ZoneId.systemDefault()
+ val locale = Locale.getDefault()
+ val formatter = new DefaultTimestampFormatter(
+ zoneId, locale, LENIENT_SIMPLE_DATE_FORMAT, isParsing = true)
+
+ val invalidTimestampStr = "2021-13-01T25:61:61"
+
+ checkError(
+ exception = intercept[SparkRuntimeException] {
+ formatter.parseWithoutTimeZone(invalidTimestampStr, allowTimeZone = false)
Review Comment:
Could you reproduce the error using public API, please. Just ask you because if we cannot do that, we should consider to convert it to an internal error.
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -298,6 +298,12 @@
],
"sqlState" : "22018"
},
+ "CANNOT_PARSE_STRING_AS_DATATYPE" : {
Review Comment:
Cannot you re-use the existing error class: `MALFORMED_RECORD_IN_PARSING.CANNOT_PARSE_STRING_AS_DATATYPE`?
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1272,6 +1278,12 @@
],
"sqlState" : "42710"
},
+ "FIELD_INDEX_ON_ROW_WITHOUT_SCHEMA" : {
+ "message" : [
+ "fieldIndex on a Row without schema is undefined."
+ ],
+ "sqlState" : "42000"
Review Comment:
How about to assign some unique number in the range `42XXX`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #45244:
URL: https://github.com/apache/spark/pull/45244#discussion_r1503550041
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TimestampFormatterSuite.scala:
##########
@@ -502,4 +504,25 @@ class TimestampFormatterSuite extends DatetimeFormatterSuite {
assert(formatter.parseOptional("9999-12-31 23:59:59.999").isEmpty)
assert(formatter.parseWithoutTimeZoneOptional("9999-12-31 23:59:59.999", true).isEmpty)
}
+
+ test("fail to parse string as TimestampNTZ with invalid format") {
+ val zoneId = ZoneId.systemDefault()
+ val locale = Locale.getDefault()
+ val formatter = new DefaultTimestampFormatter(
+ zoneId, locale, LENIENT_SIMPLE_DATE_FORMAT, isParsing = true)
+
+ val invalidTimestampStr = "2021-13-01T25:61:61"
+
+ checkError(
+ exception = intercept[SparkRuntimeException] {
+ formatter.parseWithoutTimeZone(invalidTimestampStr, allowTimeZone = false)
Review Comment:
I just realized the comment from the source code below:
```
* The formatter for timestamps which doesn't require users to specify a pattern. While formatting,
* it uses the default pattern [[TimestampFormatter.defaultPattern()]]. In parsing, it follows
* the CAST logic in conversion of strings to Catalyst's TimestampType.
```
so I believe this cannot be reproduced from user space, so we should mark it as an internal error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #45244:
URL: https://github.com/apache/spark/pull/45244#discussion_r1507640743
##########
sql/api/src/main/scala/org/apache/spark/sql/errors/DataTypeErrors.scala:
##########
@@ -261,8 +261,14 @@ private[sql] object DataTypeErrors extends DataTypeErrorsBase {
messageParameters = Map("raw" -> s"'$raw'"))
}
- def fieldIndexOnRowWithoutSchemaError(): SparkUnsupportedOperationException = {
- new SparkUnsupportedOperationException("_LEGACY_ERROR_TEMP_2231")
+ def fieldIndexOnRowWithoutSchemaError(fieldName: String): SparkUnsupportedOperationException = {
+ new SparkUnsupportedOperationException(
+ errorClass = "UNSUPPORTED_CALL.FIELD_INDEX",
+ messageParameters = Map(
+ "methodName" -> "fieldIndex",
+ "className" -> "Row",
+ "fieldName" -> fieldName)
Review Comment:
Updated. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #45244:
URL: https://github.com/apache/spark/pull/45244#issuecomment-1964254994
@itholic Thanks for the ping. I will look at it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #45244:
URL: https://github.com/apache/spark/pull/45244#issuecomment-1973827372
+1, LGTM. Merging to master.
Thank you, @itholic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #45244: [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)`
URL: https://github.com/apache/spark/pull/45244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47158][SQL] Assign proper name and `sqlState` to `_LEGACY_ERROR_TEMP_(2134|2231)` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #45244:
URL: https://github.com/apache/spark/pull/45244#issuecomment-1972445986
Updated PR description and fixed the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org