You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by chitin <gi...@git.apache.org> on 2016/12/01 11:19:55 UTC
[GitHub] incubator-eagle pull request #706: [MINOR] Sleep 1 ms after versionId was ge...
GitHub user chitin opened a pull request:
https://github.com/apache/incubator-eagle/pull/706
[MINOR] Sleep 1 ms after versionId was generated
[MINOR] Sleep 1 ms after versionId was generated
- VersionId is the same with one generated in last loop randomly, the test failed in this case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chitin/incubator-eagle MINOR_JDBCTEST
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/706.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #706
----
commit e22fe8a08e8b9b0751d8af7a5f3225f3fdb650ed
Author: chitin <ch...@gmail.com>
Date: 2016-12-01T11:16:25Z
[MINOR] Sleep 1 ms after versionId was generated
- VersionId is the same with one generated in last loop randomly, the test failed in this case.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #706: [MINOR] Sleep 1 ms after versionId was ge...
Posted by wujinhu <gi...@git.apache.org>.
Github user wujinhu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/706#discussion_r90580316
--- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-metadata-parent/alert-metadata/src/test/java/org/apache/eagle/alert/metadata/impl/JdbcImplTest.java ---
@@ -184,6 +184,11 @@ public void test_clearScheduleState() {
if (i >= 10 - maxCapacity) {
reservedOnes.add(versionId);
}
+ try {
+ Thread.sleep(1);
+ } catch (Exception e) {
--- End diff --
What does this used for in ut?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #706: [MINOR] Sleep 1 ms after versionId was generated
Posted by wujinhu <gi...@git.apache.org>.
Github user wujinhu commented on the issue:
https://github.com/apache/incubator-eagle/pull/706
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #706: [MINOR] Sleep 1 ms after versionId was ge...
Posted by chitin <gi...@git.apache.org>.
Github user chitin commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/706#discussion_r90580970
--- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-metadata-parent/alert-metadata/src/test/java/org/apache/eagle/alert/metadata/impl/JdbcImplTest.java ---
@@ -184,6 +184,11 @@ public void test_clearScheduleState() {
if (i >= 10 - maxCapacity) {
reservedOnes.add(versionId);
}
+ try {
+ Thread.sleep(1);
+ } catch (Exception e) {
--- End diff --
Make sure all versionIds genereted in all loops are different value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #706: [MINOR] Sleep 1 ms after versionId was ge...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-eagle/pull/706
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---