You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "J.Andreina (JIRA)" <ji...@apache.org> on 2015/01/21 13:58:35 UTC

[jira] [Commented] (KNOX-488) If any failure during deletion of alias from a cluster , exception thrown is misleading

    [ https://issues.apache.org/jira/browse/KNOX-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285591#comment-14285591 ] 

J.Andreina commented on KNOX-488:
---------------------------------

Please check the issue . If its sounds good let me provide a patch for the same.

> If any failure during deletion of alias from a cluster , exception thrown is misleading
> ---------------------------------------------------------------------------------------
>
>                 Key: KNOX-488
>                 URL: https://issues.apache.org/jira/browse/KNOX-488
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: KnoxCLI
>            Reporter: J.Andreina
>            Priority: Minor
>
> I was doing testing on basic error scenarios and found that :
> If any exception occurs during  deletion of aliasname from a cluster , error message displays "Failed to add credential" ( which is misleading).
> {noformat}
>  public void removeCredential(String alias, KeyStore ks) {
>     if (ks != null) {
>       try {
>         if (ks.containsAlias(alias)) {
>           ks.deleteEntry(alias);
>         }
>       } catch (KeyStoreException e) {
>         LOG.failedToAddCredential(e);
>       }
>     }
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jira] [Commented] (KNOX-488) If any failure during deletion of alias from a cluster , exception thrown is misleading

Posted by larry mccay <la...@gmail.com>.
Good catch! Please do provide a patch.
Thank you for your contributions!
On Jan 21, 2015 7:58 AM, "J.Andreina (JIRA)" <ji...@apache.org> wrote:

>
>     [
> https://issues.apache.org/jira/browse/KNOX-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285591#comment-14285591
> ]
>
> J.Andreina commented on KNOX-488:
> ---------------------------------
>
> Please check the issue . If its sounds good let me provide a patch for the
> same.
>
> > If any failure during deletion of alias from a cluster , exception
> thrown is misleading
> >
> ---------------------------------------------------------------------------------------
> >
> >                 Key: KNOX-488
> >                 URL: https://issues.apache.org/jira/browse/KNOX-488
> >             Project: Apache Knox
> >          Issue Type: Bug
> >          Components: KnoxCLI
> >            Reporter: J.Andreina
> >            Priority: Minor
> >
> > I was doing testing on basic error scenarios and found that :
> > If any exception occurs during  deletion of aliasname from a cluster ,
> error message displays "Failed to add credential" ( which is misleading).
> > {noformat}
> >  public void removeCredential(String alias, KeyStore ks) {
> >     if (ks != null) {
> >       try {
> >         if (ks.containsAlias(alias)) {
> >           ks.deleteEntry(alias);
> >         }
> >       } catch (KeyStoreException e) {
> >         LOG.failedToAddCredential(e);
> >       }
> >     }
> >   }
> > {noformat}
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>