You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/19 10:14:36 UTC

[GitHub] [maven-mvnd] hboutemy opened a new issue, #653: mvnd goal execution id display inconsistent with Maven

hboutemy opened a new issue, #653:
URL: https://github.com/apache/maven-mvnd/issues/653

   in mvnd, a running mojo is displayed as "plugin:goal @ executionid":
   ```
   :maven-compat            maven-surefire-plugin:test @ default-test
   ```
   
   but in Maven, @ syntax is for artifactid, execution id is in parenthesis:
   ```
   [INFO] --- maven-assembly-plugin:3.3.0:single (create-distro-packages) @ apache-maven ---
   ```
   
   such inconsistency will create users confusion (particularly given mvnd also uses ANSI color for mvn's @ artifactId), it would be better to align mvnd with mvn (syntax and ANSI color):
   ```
   :maven-compat            maven-surefire-plugin:test (default-test)
   ```
   
   and eventually, the current module artifact id could use the same ANSI color as mvn's "@ artifactId"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-mvnd] hboutemy commented on issue #653: mvnd goal execution id display inconsistent with Maven

Posted by GitBox <gi...@apache.org>.

hboutemy commented on issue #653:
URL: https://github.com/apache/maven-mvnd/issues/653#issuecomment-1134003572

   thanks @ppalaga for the explanation: now I understand the logic behind the choice
   
   @gnodet ok for https://github.com/gnodet/mvnd/commit/5286e84ad307e0e2f957f9de03bf8ff4a2eb122a


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-mvnd] ppalaga commented on issue #653: mvnd goal execution id display inconsistent with Maven

Posted by GitBox <gi...@apache.org>.

ppalaga commented on issue #653:
URL: https://github.com/apache/maven-mvnd/issues/653#issuecomment-1131686489

   The idea to use `@ executionId` is from me. I took it from how you can choose some specific execution from the CLI: `mvn groupId:artifactId:version@execution`. I did not think of how Maven reports the mojos in the console. I do not mind to change it to what @hboutemy proposes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-mvnd] gnodet closed issue #653: mvnd goal execution id display inconsistent with Maven

Posted by GitBox <gi...@apache.org>.

gnodet closed issue #653: mvnd goal execution id display inconsistent with Maven
URL: https://github.com/apache/maven-mvnd/issues/653


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-mvnd] gnodet commented on issue #653: mvnd goal execution id display inconsistent with Maven

Posted by GitBox <gi...@apache.org>.

gnodet commented on issue #653:
URL: https://github.com/apache/maven-mvnd/issues/653#issuecomment-1131573845

   Fwiw, the method that computes the line for a given project is:
     https://github.com/apache/maven-mvnd/blob/47c99e8b0e524ca1db3ace306542309f1adcacc9/common/src/main/java/org/mvndaemon/mvnd/common/logging/TerminalOutput.java#L763-L792


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org