You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Gris (JIRA)" <ji...@apache.org> on 2009/03/16 16:23:50 UTC
[jira] Created: (DIRMINA-675) Duplicate data from decoder
Duplicate data from decoder
---------------------------
Key: DIRMINA-675
URL: https://issues.apache.org/jira/browse/DIRMINA-675
Project: MINA
Issue Type: Bug
Affects Versions: 2.0.0-M4
Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
Reporter: Gris
Fix For: 2.0.0-M3
I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682504#action_12682504 ]
Emmanuel Lecharny commented on DIRMINA-675:
-------------------------------------------
I'm just wondering if the CircularQueue we are using to store the decoded messages is not the cause of the problem... It does not seems to be synchronized at all ... ?;(
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682358#action_12682358 ]
Gris commented on DIRMINA-675:
------------------------------
Here is a sample code, which illustrates problem: http://cid-d1d348276f87717c.skydrive.live.com/self.aspx/.Public/Apache%20Mina/MinaIssue.tar.bz2
It works well on M3 but fails on M4.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Fix For: 2.0.0-M3
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny reassigned DIRMINA-675:
-----------------------------------------
Assignee: Emmanuel Lecharny
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Assignee: Emmanuel Lecharny
> Priority: Blocker
> Fix For: 2.0.0-RC1
>
> Attachments: test.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682352#action_12682352 ]
Emmanuel Lecharny commented on DIRMINA-675:
-------------------------------------------
The fact that your program works with 2.0.0-M3 cdoes not gives us any clue about what's going on. Many things have changed since 2.0.0-M3, including the API. Something that worked in the previous version might have been working by pure luck.
Again, without a test case demonstrating the problem we can run and debug, it's mostly impossible to know where the problem is.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Fix For: 2.0.0-M3
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682530#action_12682530 ]
Emmanuel Lecharny commented on DIRMINA-675:
-------------------------------------------
One step further. I have a duplicated with a buffer containing :
in = [0, 0, 0, 6, 49, 51, 52, 49, 52, 49, 0, 0, 0, 6, 49, 51, 52, 49, 52, 49,...
As we can see, each message is 6 bytes long, and both values are the same (134141).
Pb in the CumulativeDecoder while handling buffers ?
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-675) Duplicate data from decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gris updated DIRMINA-675:
-------------------------
Description:
I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
Note. SslFilter is used.
was:I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Fix For: 2.0.0-M3
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny resolved DIRMINA-675.
---------------------------------------
Resolution: Fixed
Thanks to Steve's insight, I was able to fix the issue by using a ConcurentLinkedQueue in the AbstractProtocolEncoderOutput class. No more duplicates !
This may have an impact on performance, and we may want to check for a better solution later, but atm, it works.
Fixed in http://svn.apache.org/viewvc?rev=755181&view=rev
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Priority: Blocker
> Fix For: 2.0.0-RC1
>
> Attachments: MinaIssue.tar, test.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682367#action_12682367 ]
Gris commented on DIRMINA-675:
------------------------------
Ok. Here goes link: http://cid-d1d348276f87717c.skydrive.live.com/self.aspx/.Public/Apache%20Mina/MinaIssue.tar
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Fix For: 2.0.0-M3
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682362#action_12682362 ]
Emmanuel Lecharny commented on DIRMINA-675:
-------------------------------------------
Sorry, can't uncompress the file, as it seems not to be a bz2 file. Can you create a simple tar ?
Thanks
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Fix For: 2.0.0-M3
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682374#action_12682374 ]
Gris commented on DIRMINA-675:
------------------------------
It's very strange. I use Mozilla Firefox 2.0 under Linux, but I can both upload and download to/from skydrive. :) But anyway, file is attached.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Fix For: 2.0.0-M3
>
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682519#action_12682519 ]
Emmanuel Lecharny commented on DIRMINA-675:
-------------------------------------------
Damnit ! Even after having replaced the CircularQueue with a thread-safe ConcurrentLinkedQueue, I still get some duplicates...
Are we mixing up sessions ?
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682383#action_12682383 ]
Emmanuel Lecharny commented on DIRMINA-675:
-------------------------------------------
I have run the test with only 10 loops, and here is what I get :
aaa
[server] Ident: 1
[server] Ident: 2
[server] Ident: 3
[server] Ident: 4
[server] Ident: 5
[server] Ident: 6
[server] Ident: 7
[server] Ident: 8
[server] Ident: 9
[server] Ident: 10
[Client] Ident: 1
[Client] Ident: 2
[Client] Ident: 3
[Client] Ident: 4
[Client] Ident: 5
[Client] Ident: 6
[Client] Ident: 7
[Client] Ident: 8
[Client] Ident: 9
[Client] Ident: 10
[server] Ident: 11
[server] Ident: 12
[server] Ident: 13
[server] Ident: 14
[server] Ident: 15
[server] Ident: 16
[server] Ident: 17
[server] Ident: 18
[server] Ident: 19
[server] Ident: 20
[Client] Ident: 11
[server] Ident: 21
[Client] Ident: 12
[Client] Ident: 13
[Client] Ident: 14
[Client] Ident: 15
[Client] Ident: 16
[Client] Ident: 17
[Client] Ident: 18
[Client] Ident: 19
[Client] Ident: 20
[server] Ident: 22
[Client] Ident: 21
[Client] Ident: 22
[server] Ident: 23
[server] Ident: 24
I see no duplication of event... I'm using MINA trunk. May be we had a pb with MINA 2.0.0-M4 which has been solved in trunk.
Can you check with the trunk if your program works correctly ?
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRMINA-675:
--------------------------------------
Priority: Blocker (was: Major)
Fix Version/s: 2.0.0-RC1
Raised to blocker.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Priority: Blocker
> Fix For: 2.0.0-RC1
>
> Attachments: MinaIssue.tar, test.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (DIRMINA-675) Duplicate data from
decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682443#action_12682443 ]
Gris edited comment on DIRMINA-675 at 3/16/09 1:20 PM:
-------------------------------------------------------
The problem appears randomly. Sometimes at the beginning (20 < id < 300), sometimes a little bit later (id > 3000). In rare cases, the problem does not appear at all. I have spent a heap of tests to understand where the problem is covered. In each case the result could differ a little, but as a whole the problem was shown always.
was (Author: gris):
The problem appears randomly. Sometimes at the beginning (20 > id > 300), sometimes a little bit later (id > 3000). In rare cases, the problem does not appear at all. I have spent a heap of tests to understand where the problem is covered. In each case the result could differ a little, but as a whole the problem was shown always.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682510#action_12682510 ]
Emmanuel Lecharny commented on DIRMINA-675:
-------------------------------------------
There is a bug in the decoder. As it extends CumulativeDecoder, the position has to be reset if we can read a length but don't have all the following bytes
if (remaining >= INT_SIZE)
{
int start = in.position();
...
}
else
{
in.position( start );
return false;
}
...
I still have some duplicated values ...
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682414#action_12682414 ]
Gris commented on DIRMINA-675:
------------------------------
Upd. I ever made protocol primitive (only one long-type value), disabled ssl, but problem still exists on versions M4+.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-675) Duplicate data from decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gris updated DIRMINA-675:
-------------------------
Fix Version/s: (was: 2.0.0-M3)
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682368#action_12682368 ]
Emmanuel Lecharny commented on DIRMINA-675:
-------------------------------------------
ok, wrong explanation. I simply can't download the file because you are using a M$ soft which does not allow around 30% of the population using something better that M$ ie explorer to get the file through an aspx link :/.
More simply, just attach the file on the JIRA.
Remember that there are other system out there than just W$, and most of the apache peeps are using either Mac of a flavor of Linux ... :)
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Fix For: 2.0.0-M3
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682337#action_12682337 ]
Emmanuel Lecharny commented on DIRMINA-675:
-------------------------------------------
There is probably something wrong in your decoder, or the client. Without a minimal test code, it's almost impossible to know what's going on...
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Fix For: 2.0.0-M3
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRMINA-675:
--------------------------------------
Attachment: (was: MinaIssue.tar)
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Assignee: Emmanuel Lecharny
> Priority: Blocker
> Fix For: 2.0.0-RC1
>
> Attachments: test.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-675) Duplicate data from decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gris updated DIRMINA-675:
-------------------------
Affects Version/s: 2.0.0-RC1
Added 2.0.0-RC1 as affected too.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-675) Duplicate data from decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gris updated DIRMINA-675:
-------------------------
Attachment: MinaIssue.tar
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Fix For: 2.0.0-M3
>
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Steve Ulrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682610#action_12682610 ]
Steve Ulrich commented on DIRMINA-675:
--------------------------------------
IMHO it's the encoder, not the decoder.
Currently the IoSession.write does call the FilterChain asynchronously instead of using the MessageQueue (or am I missing something?).
So there are asynchronous are calls to ProtocolCodecFilter.ProtocolEncoderOutputImpl (they definitely exists) which does several offers and polls at the CircularQueue at same time and resulting in loss of messages or duplicate poll results (which means that a single WriteRequest is proposed more than once to the next filter).
The interesting part is, that I can't see anything that changes the logic between M3 and M4, so it could be pure luck, that it worked with M3.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Priority: Blocker
> Fix For: 2.0.0-RC1
>
> Attachments: MinaIssue.tar, test.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682431#action_12682431 ]
Gris commented on DIRMINA-675:
------------------------------
Thank you! I hope this issue will be fixed soon.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682436#action_12682436 ]
Emmanuel Lecharny commented on DIRMINA-675:
-------------------------------------------
Just to check : do you get the problem at the end of the test ?
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682663#action_12682663 ]
Gris commented on DIRMINA-675:
------------------------------
Thanks a lot. It's a big help.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Assignee: Emmanuel Lecharny
> Priority: Blocker
> Fix For: 2.0.0-RC1
>
> Attachments: test.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682417#action_12682417 ]
Emmanuel Lecharny commented on DIRMINA-675:
-------------------------------------------
I confirm . Sigh :/
I also removed the SSL part, and still get the issue. i'm using a Set instead of a vector too.
Damn !
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRMINA-675:
--------------------------------------
Attachment: test.tar
A slightly modified test which demonstrates the problem. I get from 20 to 100 random duplicates on my laptop when sending 500 000 messages
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar, test.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682341#action_12682341 ]
Gris commented on DIRMINA-675:
------------------------------
I've tested both client and server. Each message have unique id, so it was easy to trace all processing cycle. I added debug code within decoder and encoder which prints id of each processed message. There are no duplicates on this stage. Problem was solved when I rolled back to M3 *without modification of my code*.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Fix For: 2.0.0-M3
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny closed DIRMINA-675.
-------------------------------------
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-M5
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Assignee: Emmanuel Lecharny
> Priority: Blocker
> Fix For: 2.0.0-M5
>
> Attachments: test.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682496#action_12682496 ]
Emmanuel Lecharny commented on DIRMINA-675:
-------------------------------------------
After some more tests, here are some more infos :
- the test is a bit problematic, as the client sends messages as fast as possible, so the server can't return a response to all the messages. Counting the number of messages received by the client shows that we miss a lot of them.
- I'm still having some random duplicates, too.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682443#action_12682443 ]
Gris commented on DIRMINA-675:
------------------------------
The problem appears randomly. Sometimes at the beginning (20 > id > 300), sometimes a little bit later (id > 3000). In rare cases, the problem does not appear at all. I have spent a heap of tests to understand where the problem is covered. In each case the result could differ a little, but as a whole the problem was shown always.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682614#action_12682614 ]
Emmanuel Lecharny commented on DIRMINA-675:
-------------------------------------------
Good catch Steve !
I have added some check on the client side, tracking the sent message, and for every duplicated message received on the server, there is a duplicated message sent from the client ... Here are the logs :
Type return to start...
Test started
4 remaining...
3 remaining...
2 remaining...
1 remaining...
0 remaining...
Done !!!
Type return to stop...
Duplicate ident: 73780
Duplicate ident: 84208
Message 73780 already sent !
Duplicate ident: 141390
Duplicate ident: 150062
Duplicate ident: 159952
Message 84208 already sent !
Duplicate ident: 176236
Message 141390 already sent !
Message 150062 already sent !
Message 159952 already sent !
Message 176236 already sent !
Duplicate ident: 302169
Duplicate ident: 342648
Message 302169 already sent !
Message 342648 already sent !
Test stopped
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Priority: Blocker
> Fix For: 2.0.0-RC1
>
> Attachments: MinaIssue.tar, test.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-675) Duplicate data from decoder
Posted by "Gris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682392#action_12682392 ]
Gris commented on DIRMINA-675:
------------------------------
I checked out latest snapshot but I still got duplicates. It seems that you stopped test application too early. There must be an exception thrown if duplicate found. Please wait little bit longer, because time when error appears may differ.
> Duplicate data from decoder
> ---------------------------
>
> Key: DIRMINA-675
> URL: https://issues.apache.org/jira/browse/DIRMINA-675
> Project: MINA
> Issue Type: Bug
> Affects Versions: 2.0.0-M4
> Environment: Ubuntu Linux 8.10 x86, Java(TM) SE Runtime Environment (build 1.6.0_10-b33)
> Reporter: Gris
> Attachments: MinaIssue.tar
>
>
> I got duplicate messages in messageReceived(...) in my io handler adapter, but there are no such problem while decoding message (each message decoded only once). Rolling back to M3 seems solved problem.
> Note. SslFilter is used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.