You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/01/18 08:33:09 UTC

[GitHub] [zeppelin] Reamer commented on a change in pull request #4024: [ZEPPELIN-5199]. Should login via keytab first in jdbc interpreter

Reamer commented on a change in pull request #4024:
URL: https://github.com/apache/zeppelin/pull/4024#discussion_r559093375



##########
File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
##########
@@ -207,6 +207,16 @@ protected boolean runKerberosLogin() {
   @Override
   public void open() {
     super.open();
+
+    // login via keytab first in open method, otherwise the underlying runKerbose thread will
+    // fail and cause the interpreter closed.
+    String authType = properties.getProperty("zeppelin.jdbc.auth.type", "SIMPLE")
+            .trim().toUpperCase();
+    if (authType.equalsIgnoreCase("KERBEROS")) {

Review comment:
       Please swap the order of comparison. `toUpperCase()` is not necessary if you used `equalsIgnoreCase()`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org