[GitHub] [druid] somu-imply commented on a diff in pull request #13892: Various changes and fixes to UNNEST.

["somu-imply (via GitHub)" <gi...@apache.org>]

somu-imply commented on code in PR #13892:
URL: https://github.com/apache/druid/pull/13892#discussion_r1128559650


##########
processing/src/main/java/org/apache/druid/segment/UnnestStorageAdapter.java:
##########
@@ -122,12 +121,16 @@ public Sequence<Cursor> makeCursors(
             retVal = new UnnestColumnValueSelectorCursor(
                 retVal,
                 retVal.getColumnSelectorFactory(),
-                dimensionToUnnest,
+                unnestColumn,
                 outputColumnName,
                 allowSet
             );
           }
-          return retVal;
+          return PostJoinCursor.wrap(

Review Comment:
   This is nice, there's no need to pass in the allowFilter inside the data source now and the PostJoinCursor will apply the filters on unnested column which are the post join filters



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org