You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/10/01 23:19:02 UTC
[GitHub] [thrift] elludraon opened a new pull request #2252: THRIFT-5286: Fix Lua library readBool() in TCompactProtocol
elludraon opened a new pull request #2252:
URL: https://github.com/apache/thrift/pull/2252
Client: Lua
`TCompactProtocol` did not read boolean fields correctly due to code bugs.
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] elludraon commented on pull request #2252: THRIFT-5286: Fix Lua library readBool() in TCompactProtocol
Posted by GitBox <gi...@apache.org>.
elludraon commented on pull request #2252:
URL: https://github.com/apache/thrift/pull/2252#issuecomment-702926095
I copied the working Python implementation.
Tested by sending a struct with `map<string, bool>` over `TCompactProtocol` - before, the received struct was getting truncated (corrupt indices while reading).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2252: THRIFT-5286: Fix Lua library readBool() in TCompactProtocol
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2252:
URL: https://github.com/apache/thrift/pull/2252#issuecomment-702924634
How did you test it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2252: THRIFT-5286: Fix Lua library readBool() in TCompactProtocol
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2252:
URL: https://github.com/apache/thrift/pull/2252#issuecomment-702924634
Testcase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2252: THRIFT-5286: Fix Lua library readBool() in TCompactProtocol
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2252:
URL: https://github.com/apache/thrift/pull/2252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org