[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #13913: Make zk connection retries configurable

["abhishekagarwal87 (via GitHub)" <gi...@apache.org>]

abhishekagarwal87 commented on code in PR #13913:
URL: https://github.com/apache/druid/pull/13913#discussion_r1140141891


##########
server/src/main/java/org/apache/druid/curator/CuratorConfig.java:
##########
@@ -58,6 +58,12 @@
   @JsonProperty("authScheme")
   private String authScheme = "digest";
 
+  // Configures the maximum number of retries for attempting connection to Zookeeper.
+  // This config property is in place to override the retry count in case unexpected issues show up with a smaller retry count.
+  // This may be removed in the future if we determine the default value doesn't cause any unexpected issues.
+  @JsonProperty("maxZkRetries")
+  private int maxZkRetries = 5;

Review Comment:
   let's keep the default to 29 itself. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org