You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/25 12:17:00 UTC
[jira] [Commented] (FLINK-7522) Add termination future to
ClusterEntrypoint
[ https://issues.apache.org/jira/browse/FLINK-7522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141530#comment-16141530 ]
ASF GitHub Bot commented on FLINK-7522:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4589
[FLINK-7522] Add termination future to ClusterEntrypoint
## What is the purpose of the change
The termination future is completed when the `ClusterEntrypoint` shuts down. This
allows for easier testing.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink addEntrypointTerminationFuture
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4589.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4589
----
commit f3bbc0d8720ce7a0f598ae1cb524e3b4c42642f5
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-14T13:47:04Z
[FLINK-7522] Add termination future to ClusterEntrypoint
The termination future is completed when the ClusterEntrypoint shuts down. This
allows for easier testing.
----
> Add termination future to ClusterEntrypoint
> -------------------------------------------
>
> Key: FLINK-7522
> URL: https://issues.apache.org/jira/browse/FLINK-7522
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Labels: flip-6
>
> In order to wait for the termination of {{ClusterEntrypoint}}, e.g. when testing it, a termination future would be helpful.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)