[GitHub] [airflow] dstandish commented on a diff in pull request #29708: Avoid including fallback message for S3TaskHandler if streaming logs

["dstandish (via GitHub)" <gi...@apache.org>]

dstandish commented on code in PR #29708:
URL: https://github.com/apache/airflow/pull/29708#discussion_r1115028212


##########
airflow/providers/amazon/aws/log/s3_task_handler.py:
##########
@@ -128,8 +128,12 @@ def _read(self, ti, try_number, metadata=None):
         if logs:
             return "".join(f"*** {x}\n" for x in messages) + "\n".join(logs), {"end_of_log": True}
         else:
+            if metadata and "log_pos" in metadata and metadata["log_pos"] > 0:

Review Comment:
   ```suggestion
               if metadata and metadata.get("log_pos", 0) > 0:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org