You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/26 05:29:52 UTC

[GitHub] [arrow] pcmoritz opened a new pull request, #13979: ARROW-17079: Improve error messages for AWS S3 calls

pcmoritz opened a new pull request, #13979:
URL: https://github.com/apache/arrow/pull/13979

   First part of improving error messages from S3 operations. We include the operation that failed in the error message now. This makes it easier to debug problems (e.g. bucket permissions or other infrastructure hickups) because it allows to re-run the operation that failed with the AWS CLI for further diagnosing what is going wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pcmoritz commented on pull request #13979: ARROW-17079: [C++] Improve error messages for AWS S3 calls

Posted by GitBox <gi...@apache.org>.
pcmoritz commented on PR #13979:
URL: https://github.com/apache/arrow/pull/13979#issuecomment-1228167466

   @pitrou Do you want to have a look at / review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #13979: ARROW-17079: Improve error messages for AWS S3 calls

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13979:
URL: https://github.com/apache/arrow/pull/13979#issuecomment-1228069893

   :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #13979: ARROW-17079: Improve error messages for AWS S3 calls

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13979:
URL: https://github.com/apache/arrow/pull/13979#issuecomment-1228069878

   https://issues.apache.org/jira/browse/ARROW-17079


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pcmoritz merged pull request #13979: ARROW-17079: [C++] Improve error messages for AWS S3 calls

Posted by GitBox <gi...@apache.org>.
pcmoritz merged PR #13979:
URL: https://github.com/apache/arrow/pull/13979


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #13979: ARROW-17079: [C++] Improve error messages for AWS S3 calls

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13979:
URL: https://github.com/apache/arrow/pull/13979#issuecomment-1231913272

   ['Python', 'R'] benchmarks have high level of regressions.
   [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bf13cf118d084d43abd716705dc11ee8...716ec505baaa47ba8385862ebcbde968/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pcmoritz commented on pull request #13979: ARROW-17079: [C++] Improve error messages for AWS S3 calls

Posted by GitBox <gi...@apache.org>.
pcmoritz commented on PR #13979:
URL: https://github.com/apache/arrow/pull/13979#issuecomment-1230859731

   Yes of course! For example for loading a dataset from `s3://pcmoritz-test-bucket-arrow-errors/test.csv` (the bucket has all access permissions revoked):
   
   After:
   ```
   When getting information for key 'test.csv' in bucket 'pcmoritz-test-bucket-arrow-errors': AWS Error [code 15] during HeadObject call: No response body.
   ```
   
   Before:
   ```
   When getting information for key 'test.csv' in bucket 'pcmoritz-test-bucket-arrow-errors': AWS Error [code 15]: No response body.
   ```
   
   For comparison, this is the boto3 error:
   ```
   import boto3                                                                                                                                            
   client = boto3.client('s3')                                                                                                                             
   client.download_file('pcmoritz-test-bucket-arrow-errors', 'test.csv', '/tmp/test.csv')
   
   ClientError: An error occurred (400) when calling the HeadObject operation: Bad Request
   ```
   
   I'm happy to use the exact same phrasing as boto3 if that's desired -- I'll do a follow up PR with the error codes substituted with actual errors and can change it then if desired.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #13979: ARROW-17079: [C++] Improve error messages for AWS S3 calls

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13979:
URL: https://github.com/apache/arrow/pull/13979#issuecomment-1231912965

   Benchmark runs are scheduled for baseline = d7eea09ba87db7abb08f8678e3cb476e796c005d and contender = b43c6f6b18acee019a500bc6a05af18c07f2ca79. b43c6f6b18acee019a500bc6a05af18c07f2ca79 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5da710ca0744445c9d6586efeeea1d80...6bd14dc871ee4c5185d1cfcc0b4d81f1/)
   [Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e08ef2ac301946e19138bfe86bfa326b...b3a8a40c75fd40629fa338d7ca9b9dbc/)
   [Failed :arrow_down:0.55% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bf13cf118d084d43abd716705dc11ee8...716ec505baaa47ba8385862ebcbde968/)
   [Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/37a51e4d428346499f4e9f11efb15a6e...779a5e328192492ba04c93d4371bb733/)
   Buildkite builds:
   [Finished] [`b43c6f6b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1386)
   [Failed] [`b43c6f6b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1402)
   [Failed] [`b43c6f6b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1384)
   [Finished] [`b43c6f6b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1401)
   [Finished] [`d7eea09b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1385)
   [Failed] [`d7eea09b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1401)
   [Failed] [`d7eea09b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1383)
   [Failed] [`d7eea09b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1400)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org