[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #14130: add xa handler

[GitBox <gi...@apache.org>]

terrymanu commented on code in PR #14130:
URL: https://github.com/apache/shardingsphere/pull/14130#discussion_r907914220


##########
docs/document/content/features/transaction/use-norms/xa.en.md:
##########
@@ -13,3 +13,101 @@ weight = 2
 ## Unsupported
 
 * Recover committing and rolling back in other machines after the service is down.
+
+## XA Transaction managed by XA Statement

Review Comment:
   What is the different with original XA? If same, why it appear here?



##########
shardingsphere-kernel/shardingsphere-transaction/shardingsphere-transaction-core/src/main/java/org/apache/shardingsphere/transaction/core/TransactionType.java:
##########
@@ -22,7 +22,7 @@
  */
 public enum TransactionType {
     
-    LOCAL, XA, BASE;
+    LOCAL, XA, BASE, MANUALXA;

Review Comment:
   I cannot agree to add new transaction type here.
   I don't think `MANUALXA` is a valid transaction type, it is not a same abstract level with `LOCAL`, `XA` and `BASE`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org