You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by js...@apache.org on 2004/01/21 00:50:57 UTC
cvs commit: jakarta-jmeter/src/core/org/apache/jmeter/gui/action Remove.java
jsalvata 2004/01/20 15:50:57
Modified: src/core/org/apache/jmeter/gui GuiPackage.java
src/core/org/apache/jmeter/gui/action Remove.java
Log:
Fixing what's probably the most anoying GUI bug now: when
an element was deleted, its parent would be modified to
the values of the last element of the type seen.
Funny enough I could not find an entry for that in bugzilla.
Revision Changes Path
1.23 +5 -9 jakarta-jmeter/src/core/org/apache/jmeter/gui/GuiPackage.java
Index: GuiPackage.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/gui/GuiPackage.java,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- GuiPackage.java 19 Jan 2004 19:03:36 -0000 1.22
+++ GuiPackage.java 20 Jan 2004 23:50:57 -0000 1.23
@@ -419,14 +419,10 @@
*/
public void updateCurrentGui()
{
- // TODO: Would it be possible to get the current node from the
- // treeListener instead of keeping it as a separate variable?
- if (currentNode != null)
- {
- TestElement element = currentNode.createTestElement();
- JMeterGUIComponent comp = getGui(element);
- comp.configure(element);
- }
+ currentNode= treeListener.getCurrentNode();
+ TestElement element = currentNode.createTestElement();
+ JMeterGUIComponent comp = getGui(element);
+ comp.configure(element);
}
/**
1.8 +2 -4 jakarta-jmeter/src/core/org/apache/jmeter/gui/action/Remove.java
Index: Remove.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/gui/action/Remove.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- Remove.java 16 Oct 2003 17:37:41 -0000 1.7
+++ Remove.java 20 Jan 2004 23:50:57 -0000 1.8
@@ -105,9 +105,7 @@
removeNode(nodes[i]);
}
guiPackage.getTreeListener().getJTree().setSelectionPath(newTreePath);
-
- //guiPackage.getTreeListener().getJTree().setSelectionRow(1);
-
+ guiPackage.updateCurrentGui();
}
public static void removeNode(JMeterTreeNode node)
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org