You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2017/10/13 00:15:12 UTC

[GitHub] spark pull request #19480: [SPARK-22226][SQL] splitExpression can create too...

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19480#discussion_r144440892
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ---
    @@ -1010,6 +1079,8 @@ object CodeGenerator extends Logging {
       // This is the value of HugeMethodLimit in the OpenJDK JVM settings
       val DEFAULT_JVM_HUGE_METHOD_LIMIT = 8000
     
    +  val MERGE_SPLIT_METHODS_THRESHOLD = 3
    --- End diff --
    
    Let's add a short comment for this too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org