You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apex.apache.org by tweise <gi...@git.apache.org> on 2015/09/24 08:55:51 UTC

[GitHub] incubator-apex-core pull request: License header format - REVIEW O...

GitHub user tweise opened a pull request:

    https://github.com/apache/incubator-apex-core/pull/73

    License header format - REVIEW ONLY

    This diff was produced by adjusting the exclusions for the licensing plugin and then running format:
    
    ```
    mvn license:format -Dlicense.skip=false
    ```
    I intentionally did not change the license header template just yet, first want to get the exclusions right and ensure the formatting is correct (there are a few manual adjustments needed).
    
    Would appreciate review, are all files that should have a header captured, are there any files that should be excluded?
    
    Once the automation works and we have accounted for manual tweaks, we can simply regenerate with the expected ASF header.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tweise/incubator-apex-core license-header-format

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-core/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #73
    
----
commit 4db9c754e705bee81cff0ed87e7f4af248763c17
Author: Thomas Weise <th...@datatorrent.com>
Date:   2015-09-24T06:29:12Z

    tweak license exclusions

commit 40cb05eafb9af8542cfe466b6028a5fd03ac3928
Author: Thomas Weise <th...@datatorrent.com>
Date:   2015-09-24T06:48:07Z

    Test formatting.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: License header format

Posted by tweise <gi...@git.apache.org>.
GitHub user tweise reopened a pull request:

    https://github.com/apache/incubator-apex-core/pull/73

    License header format

    This diff was produced by adjusting the exclusions for the licensing plugin and then running format:
    
    ```
    mvn license:format -Dlicense.skip=false
    ```
    I intentionally did not change the license header template just yet, first want to get the exclusions right and ensure the formatting is correct (there are a few manual adjustments needed).
    
    Would appreciate review, are all files that should have a header captured, are there any files that should be excluded?
    
    Once the automation works and we have accounted for manual tweaks, we can simply regenerate with the expected ASF header.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tweise/incubator-apex-core license-header-format

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-core/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #73
    
----
commit 78cef72dc17c5e8262b3750536b979f4f05b3fc0
Author: Chris Nauroth <cn...@hortonworks.com>
Date:   2015-09-24T21:57:24Z

    Enforce Apache licensing requirements in Apex Core using apache-rat-plugin.

commit 1b88ad8a8d7e5f87dff83bc6ab69ed36c747ea2f
Author: Thomas Weise <th...@datatorrent.com>
Date:   2015-09-24T22:22:46Z

    Remove leading blank lines that prevent license header automation.

commit 12970c4f216f6cd1a35fbc5de517a24185c01890
Author: Thomas Weise <th...@datatorrent.com>
Date:   2015-09-24T22:33:27Z

    Prepare for license header format: Use ASF header and apply to applicable non-Java files.

commit a9486515ce5450afc1be9e63555e714c14a427b5
Author: Thomas Weise <th...@datatorrent.com>
Date:   2015-09-25T01:05:58Z

    mapping for dtcli script header

commit d79258f80f6323055db8b31363d6546f768d63dc
Author: Thomas Weise <th...@datatorrent.com>
Date:   2015-09-25T01:09:49Z

    Additional rat exclusions.

commit 6345be337b0b83c7a44ccb94c78c1be4aae91870
Author: MalharJenkins <je...@datatorrent.com>
Date:   2015-09-25T01:15:03Z

    Merge branch 'license-rat' into license-header-format

commit 730e57f78d44874db7be7ecf89497cf0010e1c55
Author: MalharJenkins <je...@datatorrent.com>
Date:   2015-09-25T01:19:33Z

    Automated license header format:
    mvn license:format -Dlicense.skip=false
    
    Check:
    mvn apache-rat:check

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: License header format

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-apex-core/pull/73


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: License header format

Posted by tweise <gi...@git.apache.org>.
Github user tweise closed the pull request at:

    https://github.com/apache/incubator-apex-core/pull/73


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---