You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/04/28 03:05:33 UTC
[GitHub] [rocketmq-client-go] xujianhai666 commented on a change in pull request #427: [ISSUE #421] feat: support ipv6
xujianhai666 commented on a change in pull request #427:
URL: https://github.com/apache/rocketmq-client-go/pull/427#discussion_r416292200
##########
File path: internal/remote/tcp_conn.go
##########
@@ -40,6 +48,19 @@ func initConn(ctx context.Context, addr string) (*tcpConnWrapper, error) {
}, nil
}
+// reference by net.ParseIP
+func isIPV4(s string) bool {
+ for i := 0; i < len(s); i++ {
+ switch s[i] {
+ case '.':
+ return true
Review comment:
we just justify ipv6 or ipv6, domain name never runn into here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org