You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jason Smith (JIRA)" <ji...@codehaus.org> on 2010/12/03 20:58:03 UTC
[jira] Created: (MDEP-295) Add ability to strip classifier
Add ability to strip classifier
-------------------------------
Key: MDEP-295
URL: http://jira.codehaus.org/browse/MDEP-295
Project: Maven 2.x Dependency Plugin
Issue Type: Improvement
Reporter: Jason Smith
Assignee: Brian Fox
In addition to the ability to specify that the version be stripped from the artifact it would be helpful to be able to specify that the classifier be stripped also.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MDEP-295) Add ability to strip classifier
Posted by "ee (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ee updated MDEP-295:
--------------------
Attachment: episode3.patch
> Add ability to strip classifier
> -------------------------------
>
> Key: MDEP-295
> URL: https://jira.codehaus.org/browse/MDEP-295
> Project: Maven 2.x Dependency Plugin
> Issue Type: Improvement
> Reporter: Jason Smith
> Assignee: Brian Fox
> Attachments: 0002-stripClassifier-option-added-to-the-copy-dependency-.patch, episode3.patch, good.patch
>
>
> In addition to the ability to specify that the version be stripped from the artifact it would be helpful to be able to specify that the classifier be stripped also.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MDEP-295) Add ability to strip classifier
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Gier updated MDEP-295:
---------------------------
Assignee: (was: Paul Gier)
> Add ability to strip classifier
> -------------------------------
>
> Key: MDEP-295
> URL: https://jira.codehaus.org/browse/MDEP-295
> Project: Maven 2.x Dependency Plugin
> Issue Type: Improvement
> Components: copy-dependencies
> Reporter: Jason Smith
> Attachments: 0002-stripClassifier-option-added-to-the-copy-dependency-.patch, episode3.patch, good.patch
>
>
> In addition to the ability to specify that the version be stripped from the artifact it would be helpful to be able to specify that the classifier be stripped also.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MDEP-295) Add ability to strip classifier
Posted by "ee (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ee updated MDEP-295:
--------------------
Attachment: good.patch
Ups, this is the good patch. Please ignore the previous one.
> Add ability to strip classifier
> -------------------------------
>
> Key: MDEP-295
> URL: https://jira.codehaus.org/browse/MDEP-295
> Project: Maven 2.x Dependency Plugin
> Issue Type: Improvement
> Reporter: Jason Smith
> Assignee: Brian Fox
> Attachments: 0002-stripClassifier-option-added-to-the-copy-dependency-.patch, good.patch
>
>
> In addition to the ability to specify that the version be stripped from the artifact it would be helpful to be able to specify that the classifier be stripped also.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MDEP-295) Add ability to strip classifier
Posted by "ee (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=279351#comment-279351 ]
ee commented on MDEP-295:
-------------------------
Sure, check episode3.patch.
> Add ability to strip classifier
> -------------------------------
>
> Key: MDEP-295
> URL: https://jira.codehaus.org/browse/MDEP-295
> Project: Maven 2.x Dependency Plugin
> Issue Type: Improvement
> Reporter: Jason Smith
> Assignee: Brian Fox
> Attachments: 0002-stripClassifier-option-added-to-the-copy-dependency-.patch, episode3.patch, good.patch
>
>
> In addition to the ability to specify that the version be stripped from the artifact it would be helpful to be able to specify that the classifier be stripped also.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MDEP-295) Add ability to strip classifier
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Gier updated MDEP-295:
---------------------------
Component/s: copy-dependencies
Assignee: Paul Gier (was: Brian Fox)
Unfortunately, it looks like the patch became out of date with some recent changes to the copy-dependencies mojo. Any possibility you can provide one more update?
> Add ability to strip classifier
> -------------------------------
>
> Key: MDEP-295
> URL: https://jira.codehaus.org/browse/MDEP-295
> Project: Maven 2.x Dependency Plugin
> Issue Type: Improvement
> Components: copy-dependencies
> Reporter: Jason Smith
> Assignee: Paul Gier
> Attachments: 0002-stripClassifier-option-added-to-the-copy-dependency-.patch, episode3.patch, good.patch
>
>
> In addition to the ability to specify that the version be stripped from the artifact it would be helpful to be able to specify that the classifier be stripped also.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MDEP-295) Add ability to strip classifier
Posted by "ee (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ee updated MDEP-295:
--------------------
Attachment: 0002-stripClassifier-option-added-to-the-copy-dependency-.patch
Patch is in git format, please ping me if you need in any other format.
> Add ability to strip classifier
> -------------------------------
>
> Key: MDEP-295
> URL: https://jira.codehaus.org/browse/MDEP-295
> Project: Maven 2.x Dependency Plugin
> Issue Type: Improvement
> Reporter: Jason Smith
> Assignee: Brian Fox
> Attachments: 0002-stripClassifier-option-added-to-the-copy-dependency-.patch
>
>
> In addition to the ability to specify that the version be stripped from the artifact it would be helpful to be able to specify that the classifier be stripped also.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MDEP-295) Add ability to strip classifier
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=279214#comment-279214 ]
Olivier Lamy commented on MDEP-295:
-----------------------------------
Hello,
Thanks for the patch.
But generally we like to not break backward compat.
And such diff can causes pain :
- public static String getFormattedFileName( Artifact artifact, boolean removeVersion, boolean prependGroupId )
+ public static String getFormattedFileName( Artifact artifact, boolean removeVersion, boolean removeClassifier, boolean prependGroupId )
IMHO The new parameter must be at the end of the new method and the old method must be preserve.
Can you take care of this with a new patch ?
Thanks
> Add ability to strip classifier
> -------------------------------
>
> Key: MDEP-295
> URL: https://jira.codehaus.org/browse/MDEP-295
> Project: Maven 2.x Dependency Plugin
> Issue Type: Improvement
> Reporter: Jason Smith
> Assignee: Brian Fox
> Attachments: 0002-stripClassifier-option-added-to-the-copy-dependency-.patch, good.patch
>
>
> In addition to the ability to specify that the version be stripped from the artifact it would be helpful to be able to specify that the classifier be stripped also.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MDEP-295) Add ability to strip
classifier
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=279214#comment-279214 ]
Olivier Lamy edited comment on MDEP-295 at 9/17/11 2:43 AM:
------------------------------------------------------------
Hello,
Thanks for the patch.
But generally we like to not break backward compat.
And such diff can causes pain :
\- public static String getFormattedFileName( Artifact artifact, boolean removeVersion, boolean prependGroupId )
\+ public static String getFormattedFileName( Artifact artifact, boolean removeVersion, boolean removeClassifier, boolean prependGroupId )
IMHO The new parameter must be at the end of the new method and the old method must be preserve.
Can you take care of this with a new patch ?
Thanks
was (Author: olamy):
Hello,
Thanks for the patch.
But generally we like to not break backward compat.
And such diff can causes pain :
- public static String getFormattedFileName( Artifact artifact, boolean removeVersion, boolean prependGroupId )
+ public static String getFormattedFileName( Artifact artifact, boolean removeVersion, boolean removeClassifier, boolean prependGroupId )
IMHO The new parameter must be at the end of the new method and the old method must be preserve.
Can you take care of this with a new patch ?
Thanks
> Add ability to strip classifier
> -------------------------------
>
> Key: MDEP-295
> URL: https://jira.codehaus.org/browse/MDEP-295
> Project: Maven 2.x Dependency Plugin
> Issue Type: Improvement
> Reporter: Jason Smith
> Assignee: Brian Fox
> Attachments: 0002-stripClassifier-option-added-to-the-copy-dependency-.patch, good.patch
>
>
> In addition to the ability to specify that the version be stripped from the artifact it would be helpful to be able to specify that the classifier be stripped also.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira