You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jorge Quilcate (JIRA)" <ji...@apache.org> on 2017/05/19 21:05:04 UTC
[jira] [Comment Edited] (KAFKA-5266) Follow-up improvements for
consumer offset reset tool (KIP-122)
[ https://issues.apache.org/jira/browse/KAFKA-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018004#comment-16018004 ]
Jorge Quilcate edited comment on KAFKA-5266 at 5/19/17 9:04 PM:
----------------------------------------------------------------
[~hachikuji] Thanks!
For case 3, maybe `now` could be less verbose but I like `current` also. I'd avoid adding `*-offsets` to the option name because it is kind of implicit from the main `reset-offsets`. But definitely it is better having an explicit option. Any preference between `now` and `current`?
For 4, this will be possible only when you set the topic partition manually, right? What if we filter the topicPartitions from allTopics, so if you put some unassigned topic partition you will get an empty list of topicPartitions from #getPartitionsToReset. Check it here: https://github.com/jeqo/kafka/blob/f1a4c5236984de348d4928450c5c0ad5112b6012/core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala#L548
was (Author: jeqo):
[~hachikuji] Thanks!
For case 3, maybe `--now` could be less verbose but I like `--current` also. I'd avoid adding `*-offsets` to the option name because it is kind of implicit from the main `reset-offsets`. But definitely it is better having an explicit option. Any preference between `--now` and `--current`?
For 4, this will be possible only when you set the topic partition manually, right? What if we filter the topicPartitions from allTopics, so if you put some unassigned topic partition you will get an empty list of topicPartitions from #getPartitionsToReset. Check it here: https://github.com/jeqo/kafka/blob/f1a4c5236984de348d4928450c5c0ad5112b6012/core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala#L548
> Follow-up improvements for consumer offset reset tool (KIP-122)
> ---------------------------------------------------------------
>
> Key: KAFKA-5266
> URL: https://issues.apache.org/jira/browse/KAFKA-5266
> Project: Kafka
> Issue Type: Bug
> Components: tools
> Reporter: Jason Gustafson
> Assignee: Jorge Quilcate
> Fix For: 0.11.0.0
>
>
> 1. We should try to ensure that offsets are in range for the topic partition. We currently only verify this for the shift option.
> 2. If you provide a CSV file, you shouldn't need to specify one of the --all-topics or --topic options.
> 3. We currently support a "reset to current offsets" option if none of the supported reset options are provided. This seems kind of useless. Perhaps we should just enforce that one of the reset options is provided.
> 4. The command fails with an NPE if we cannot find one of the offsets we are trying to reset. It would be better to raise an exception with a friendlier message.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)