You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/03/08 19:19:38 UTC

[GitHub] ccollins476ad commented on issue #888: kernel/os: Make sure correct stack aligment

ccollins476ad commented on issue #888: kernel/os: Make sure correct stack aligment 
URL: https://github.com/apache/mynewt-core/pull/888#issuecomment-371594036
 
 
   Good catch.  It looks like there is another related issue.  `os_malloc()` doesn't always return 8-byte aligned blocks.  Some apps (e.g., slinky) malloc task stacks.  If the allocated stack is only 4-byte aligned, then we'll have this same issue.  This happened to me when I was testing the floating point printf PR with the slinky app.
   
   Just for completeness (n1570, 7.22.3 (Memory management functions)):
   > The pointer returned if the allocation succeeds is suitably aligned so that it may be assigned to a pointer to any type of object with a fundamental alignment requirement
   
   I will file a separate PR for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services