You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aIbrahiim (via GitHub)" <gi...@apache.org> on 2026/09/07 11:19:32 UTC
[PR] fix WriteToBigTable DirectRow [beam]
aIbrahiim opened a new pull request, #40042:
URL: https://github.com/apache/beam/pull/40042
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix WriteToBigTable DirectRow [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping merged PR #40042:
URL: https://github.com/apache/beam/pull/40042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix WriteToBigTable DirectRow [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #40042:
URL: https://github.com/apache/beam/pull/40042#issuecomment-5597964189
@shunping also XLang still has the _get_mutation_pbs / _get_mutations from #40029, so should we keep that or drop the old _get_mutations path in this PR now that setup.py requires >=2.44?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix WriteToBigTable DirectRow [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #40042:
URL: https://github.com/apache/beam/pull/40042#issuecomment-5587932312
cc: @mutianf
Also we should regenerate Python requirement, especially bump this line: https://github.com/apache/beam/blob/c4cfdefa123ae7077828d734f2a584df9196ea04/sdks/python/container/py310/base_image_requirements.txt#L67
should fix the issue. cc: @shunping ( regenerate Python requirement then release a new beam-master image)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix WriteToBigTable DirectRow [beam]
Posted by "Amar3tto (via GitHub)" <gi...@apache.org>.
Amar3tto commented on PR #40042:
URL: https://github.com/apache/beam/pull/40042#issuecomment-5584218845
Tested: https://github.com/apache/beam/actions/runs/34204205571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix WriteToBigTable DirectRow [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #40042:
URL: https://github.com/apache/beam/pull/40042#issuecomment-5588165614
I didn't know there would be an issue on pickling here. How about we just bump the lower bound of bigtable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix WriteToBigTable DirectRow [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40042:
URL: https://github.com/apache/beam/pull/40042#issuecomment-5570598116
Assigning reviewers:
R: @damccorm for label python.
R: @igorbernstein2 for label bigtable.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix WriteToBigTable DirectRow [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #40042:
URL: https://github.com/apache/beam/pull/40042#issuecomment-5590558678
@Abacn thanks, I can bump bigtable to >=2.44.0 in setup.py and drop the pickle fix
@shunping would you regenerate the Python container requirements and publish a new beam-master image so workers get 2.44 too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix WriteToBigTable DirectRow [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #40042:
URL: https://github.com/apache/beam/pull/40042#issuecomment-5603965125
I gave that a second thought, and I think we have to keep the old code path for now so that the internal tests would not be broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix WriteToBigTable DirectRow [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #40042:
URL: https://github.com/apache/beam/pull/40042#issuecomment-5591958225
Sure. We can help generate the new beam image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix WriteToBigTable DirectRow [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #40042:
URL: https://github.com/apache/beam/pull/40042#issuecomment-5597901737
> Sure. We can help generate the new beam image.
Thanks, I bumped the lower bound and removed the pickle fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org