[GitHub] [twill] chtyim commented on a change in pull request #84: (TWILL-265) Upgrading kafka version and removing lz4 dependency

[GitBox <gi...@apache.org>]

chtyim commented on a change in pull request #84: (TWILL-265) Upgrading kafka version and removing lz4 dependency
URL: https://github.com/apache/twill/pull/84#discussion_r367742700
 
 

 ##########
 File path: twill-core/src/test/java/org/apache/twill/kafka/client/KafkaTest.java
 ##########
 @@ -135,6 +135,9 @@ public void finished() {
           server = new EmbeddedKafkaServer(kafkaServerConfig);
           server.startAndWait();
 
+          // Wait a little while to make sure changes is reflected in broker service
+          TimeUnit.SECONDS.sleep(3);
 
 Review comment:
   It is probably worth to expose the `BrokerService` from the `KafkaClient` and you can have a more efficient wait by use the `BrokerService.addChangeListener` method or simply poll from the `BrokerService.getBrokerList()` method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services