You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2015/04/28 21:37:22 UTC
[1/4] [lang] LANG-1118 Adding a test case for
StringUtils.repeat(String, int) checking dealing with negative repeat value
Repository: commons-lang
Updated Branches:
refs/heads/master 8e7df02ed -> 0799f01df
LANG-1118 Adding a test case for StringUtils.repeat(String, int) checking dealing with negative repeat value
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/4ad74f44
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/4ad74f44
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/4ad74f44
Branch: refs/heads/master
Commit: 4ad74f449258781e9df189413423ffd6ad95c526
Parents: 1b9d938
Author: Loic Guibert <lf...@yahoo.fr>
Authored: Thu Apr 23 15:43:21 2015 +0400
Committer: Benedikt Ritter <br...@apache.org>
Committed: Tue Apr 28 21:32:54 2015 +0200
----------------------------------------------------------------------
src/test/java/org/apache/commons/lang3/StringUtilsTest.java | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/4ad74f44/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
index 8cac696..3addd78 100644
--- a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
@@ -1353,6 +1353,7 @@ public class StringUtilsTest {
assertEquals("", StringUtils.repeat("ab", 0));
assertEquals("", StringUtils.repeat("", 3));
assertEquals("aaa", StringUtils.repeat("a", 3));
+ assertEquals("", StringUtils.repeat("a", -2));
assertEquals("ababab", StringUtils.repeat("ab", 3));
assertEquals("abcabcabc", StringUtils.repeat("abc", 3));
final String str = StringUtils.repeat("a", 10000); // bigger than pad limit
[3/4] [lang] Add LANG-1118 to changes.xml
Posted by br...@apache.org.
Add LANG-1118 to changes.xml
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/84c5e8c7
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/84c5e8c7
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/84c5e8c7
Branch: refs/heads/master
Commit: 84c5e8c7124dbecc9243dbd0313b3b94c7185f63
Parents: 4ad74f4
Author: Benedikt Ritter <br...@apache.org>
Authored: Tue Apr 28 21:35:16 2015 +0200
Committer: Benedikt Ritter <br...@apache.org>
Committed: Tue Apr 28 21:35:16 2015 +0200
----------------------------------------------------------------------
src/changes/changes.xml | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/84c5e8c7/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 5918d80..d2416b4 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -22,6 +22,7 @@
<body>
<release version="3.5" date="tba" description="tba">
+ <action issue="LANG-1118" type="fix" dev="britter" due-to="Loic Guibert">StringUtils.repeat('z', -1) throws NegativeArraySizeException</action>
<action issue="LANG-1099" type="add" dev="britter" due-to="Adrian Ber">Add swap and shift operations for arrays to ArrayUtils</action>
<action issue="LANG-979" type="update" dev="britter" due-to="Bruno P. Kinoshita">TypeUtils.parameterizeWithOwner - wrong format descriptor for "invalid number of type parameters".</action>
<action issue="LANG-1112" type="update" dev="britter">MultilineRecursiveToStringStyle largely unusable due to being package-private.</action>
[2/4] [lang] LANG-1118 Fix StringUtils.repeat(char,
int) dealing with negative repeat value
Posted by br...@apache.org.
LANG-1118 Fix StringUtils.repeat(char, int) dealing with negative repeat value
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/1b9d938d
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/1b9d938d
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/1b9d938d
Branch: refs/heads/master
Commit: 1b9d938d66a172b200fd90d4a61707852bdb4b8f
Parents: 8e7df02
Author: Loic Guibert <lf...@yahoo.fr>
Authored: Thu Apr 23 15:41:51 2015 +0400
Committer: Benedikt Ritter <br...@apache.org>
Committed: Tue Apr 28 21:32:54 2015 +0200
----------------------------------------------------------------------
src/main/java/org/apache/commons/lang3/StringUtils.java | 3 +++
src/test/java/org/apache/commons/lang3/StringUtilsTest.java | 7 +++++++
2 files changed, 10 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/1b9d938d/src/main/java/org/apache/commons/lang3/StringUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java b/src/main/java/org/apache/commons/lang3/StringUtils.java
index 360185c..2624572 100644
--- a/src/main/java/org/apache/commons/lang3/StringUtils.java
+++ b/src/main/java/org/apache/commons/lang3/StringUtils.java
@@ -5233,6 +5233,9 @@ public class StringUtils {
* @see #repeat(String, int)
*/
public static String repeat(final char ch, final int repeat) {
+ if (repeat <= 0) {
+ return EMPTY;
+ }
final char[] buf = new char[repeat];
for (int i = repeat - 1; i >= 0; i--) {
buf[i] = ch;
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/1b9d938d/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
index 5721dbc..8cac696 100644
--- a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
@@ -1375,6 +1375,13 @@ public class StringUtilsTest {
}
@Test
+ public void testRepeat_CharInt() {
+ assertEquals("zzz", StringUtils.repeat('z', 3));
+ assertEquals("", StringUtils.repeat('z', 0));
+ assertEquals("", StringUtils.repeat('z', -2));
+ }
+
+ @Test
public void testChop() {
final String[][] chopCases = {
[4/4] [lang] Merge branch 'fix-LANG-1118'
Posted by br...@apache.org.
Merge branch 'fix-LANG-1118'
LANG-1118: StringUtils.repeat('z', -1) throws NegativeArraySizeException.
Thanks to Loic Guibert.
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/0799f01d
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/0799f01d
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/0799f01d
Branch: refs/heads/master
Commit: 0799f01df18c8f2d5695390cfc6db807fe019b18
Parents: 8e7df02 84c5e8c
Author: Benedikt Ritter <br...@apache.org>
Authored: Tue Apr 28 21:35:34 2015 +0200
Committer: Benedikt Ritter <br...@apache.org>
Committed: Tue Apr 28 21:35:34 2015 +0200
----------------------------------------------------------------------
src/changes/changes.xml | 1 +
src/main/java/org/apache/commons/lang3/StringUtils.java | 3 +++
src/test/java/org/apache/commons/lang3/StringUtilsTest.java | 8 ++++++++
3 files changed, 12 insertions(+)
----------------------------------------------------------------------