You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/04/18 20:52:42 UTC
[jira] [Commented] (FLUME-1128) Conf poller should use schedule
with fixed delay
[ https://issues.apache.org/jira/browse/FLUME-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256819#comment-13256819 ]
jiraposter@reviews.apache.org commented on FLUME-1128:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4791/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
As of now, this does not cause any issues. But if we were to increase the number of threads for some reason(say we add a 2nd configuration file), then it is possible for a 2nd conf poller to start up before the first one is done. So making this code clearer, by making it single threaded executor and also calling fixed delay rather than fixed rate.
This addresses bug FLUME-1128.
https://issues.apache.org/jira/browse/FLUME-1128
Diffs
-----
flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java 64f4e35
Diff: https://reviews.apache.org/r/4791/diff
Testing
-------
All tests pass. Functional testing done.
Thanks,
Hari
> Conf poller should use schedule with fixed delay
> -------------------------------------------------
>
> Key: FLUME-1128
> URL: https://issues.apache.org/jira/browse/FLUME-1128
> Project: Flume
> Issue Type: Bug
> Components: Node
> Affects Versions: v1.1.0
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Priority: Minor
> Fix For: v1.2.0
>
> Attachments: FLUME-1128.patch
>
>
> Not a major issue, but we should be polling with fixed delay, not at fixed rate. Since we have only one thread, even the scheduleAtFixedRate works the same way, but just making sure the code is cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira