You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Attila Doroszlai (Jira)" <ji...@apache.org> on 2025/12/15 20:37:00 UTC
[jira] [Commented] (HDDS-14170) No need to copy BucketEncryptionKeyInfo and DefaultReplicationConfig
[ https://issues.apache.org/jira/browse/HDDS-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18045279#comment-18045279 ]
Attila Doroszlai commented on HDDS-14170:
-----------------------------------------
[~russole], thanks for picking this up. Would you mind keeping this unassigned until you can start working on it? Someone may be able to get to it earlier. If noone does, it's fine to pick this up again later.
> No need to copy BucketEncryptionKeyInfo and DefaultReplicationConfig
> --------------------------------------------------------------------
>
> Key: HDDS-14170
> URL: https://issues.apache.org/jira/browse/HDDS-14170
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: common
> Reporter: Attila Doroszlai
> Assignee: Chen-Jheng Sing
> Priority: Major
>
> {{OmBucketInfo#copyObject}} unnecessarily creates copies of {{BucketEncryptionKeyInfo}} and {{DefaultReplicationConfig}}, neither of which has any mutable state.
> - Simplify {{OmBucketInfo#copyObject}} implementation as {{toBuilder().build()}}
> - Delete {{copy()}} in both classes
> - Annotate {{BucketEncryptionKeyInfo}} as {{@Immutable}}
> - Implement {{equals()}} and {{hashCode()}} in {{BucketEncryptionKeyInfo}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org