You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by Alan Carvalho de Assis <ac...@gmail.com> on 2020/01/10 09:58:08 UTC
Sending .patch
Hi Everyone,
As told I opened an Infra ticket to fix sending .patch to dev@ list.
That was the response I received:
" [ https://issues.apache.org/jira/browse/INFRA-19691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012638#comment-17012638
]
Sebb commented on INFRA-19691:
------------------------------
The content-type will depend on the mail client.
I just tried with GMail, and it sent the file test.txt as
Content-Type: text/plain; charset="US-ASCII"; name="test.txt"
whereas test.patch resulted in:
Content-Type: application/octet-stream; name="test.patch"
==
However, it's usually not ideal to send patches to mailing lists.
Better to use an issue tracking system."
Then he just Closed the ticket with the resolution: Information Provided
BR,
Alan
Re: Sending .patch
Posted by Alan Carvalho de Assis <ac...@gmail.com>.
Hi Dave,
On 1/27/20, Dave Marples <da...@marples.net> wrote:
>
> Yes, I saw that, but a patch probably should be an octet-stream since we
> can't be certain what character set it's sent in. Does that mean this is
> a 'won't fix'?
>
Yes, Apache INFRA doesn't allow octect-stream attachments.
BR,
Alan
Re: Sending .patch
Posted by Nathan Hartman <ha...@gmail.com>.
On Mon, Jan 27, 2020 at 7:22 PM Dave Marples <da...@marples.net> wrote:
> On 28/01/2020 00:11, Alan Carvalho de Assis wrote:
> > The issue is because GMail and some email servers/clients will convert
> > the patch to octet-stream, please see the discussion here:
> >
> > https://issues.apache.org/jira/browse/INFRA-19691
>
> Yes, I saw that, but a patch probably should be an octet-stream since we
> can't be certain what character set it's sent in.
Does this mean that our instructions should say to send all patches in UTF8
in addition to using .txt extension?
And if so, what git incantation will do that?
Nathan
Re: Sending .patch
Posted by Dave Marples <da...@marples.net>.
On 28/01/2020 00:11, Alan Carvalho de Assis wrote:
> Hi Dave,
>
> The issue is because GMail and some email servers/clients will convert
> the patch to octet-stream, please see the discussion here:
>
> https://issues.apache.org/jira/browse/INFRA-19691
>
> BR,
>
> Alan
>
Yes, I saw that, but a patch probably should be an octet-stream since we
can't be certain what character set it's sent in. Does that mean this is
a 'won't fix'?
Regards
DAVE
Re: Sending .patch
Posted by Alan Carvalho de Assis <ac...@gmail.com>.
Hi Dave,
The issue is because GMail and some email servers/clients will convert
the patch to octet-stream, please see the discussion here:
https://issues.apache.org/jira/browse/INFRA-19691
BR,
Alan
On 1/27/20, Dave Marples <da...@marples.net> wrote:
>
>> Our workflow document already instructs users to send their patches with
>> a
>> .txt extension because of this issue.
>>
>> I just noticed that the git command given there doesn't correspond to
>> that.
>> I will fix that when I get to my computer soon. (I use 'git format-patch
>> master --stdout > your_file_name_here.txt'; I don't know if there's
>> another
>> way that requires less typing.)
>>
>> That's all we can do on our end. It would take an act of Infra to change
>> that.
>>
>> Nathan
>>
> Probably not a good idea to walk back in the door and start moaning, but
> why is that a problem? If it's wrong, then it's wrong...otherwise it's
> one more little foible people have to know about to be able to work with
> us.
>
> Regards
>
> DAVE
>
>
>
Re: Sending .patch
Posted by Dave Marples <da...@marples.net>.
> Our workflow document already instructs users to send their patches with a
> .txt extension because of this issue.
>
> I just noticed that the git command given there doesn't correspond to that.
> I will fix that when I get to my computer soon. (I use 'git format-patch
> master --stdout > your_file_name_here.txt'; I don't know if there's another
> way that requires less typing.)
>
> That's all we can do on our end. It would take an act of Infra to change
> that.
>
> Nathan
>
Probably not a good idea to walk back in the door and start moaning, but
why is that a problem? If it's wrong, then it's wrong...otherwise it's
one more little foible people have to know about to be able to work with us.
Regards
DAVE
Re: Sending .patch
Posted by Gregory Nutt <sp...@gmail.com>.
>>> As told I opened an Infra ticket to fix sending .patch to dev@ list.
>>>
>>> That was the response I received:
>>>
>>> " [
>> https://issues.apache.org/jira/browse/INFRA-19691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012638#comment-17012638
>>> ]
>>>
>>> Sebb commented on INFRA-19691:
>>> ------------------------------
>>>
>>> The content-type will depend on the mail client.
>>>
>>> I just tried with GMail, and it sent the file test.txt as
>>> Content-Type: text/plain; charset="US-ASCII"; name="test.txt"
>>>
>>> whereas test.patch resulted in:
>>> Content-Type: application/octet-stream; name="test.patch"
>>>
>>> ==
>>>
>>> However, it's usually not ideal to send patches to mailing lists.
>>> Better to use an issue tracking system."
>>>
>>> Then he just Closed the ticket with the resolution: Information Provided
>> So, will this be fixed or not? Tools are there to support users and
>> throwing away patches because the tools are sulky doesn't sound like
>> very support-y to me?
Apache email support is very limited
An option is to attach patches to Issues in the github incubator-nuttx
Issue list.
Re: Sending .patch
Posted by Nathan Hartman <ha...@gmail.com>.
On Mon, Jan 27, 2020 at 5:58 PM Dave Marples <da...@marples.net> wrote:
>
> On 10/01/2020 09:58, Alan Carvalho de Assis wrote:
> > Hi Everyone,
> >
> > As told I opened an Infra ticket to fix sending .patch to dev@ list.
> >
> > That was the response I received:
> >
> > " [
> https://issues.apache.org/jira/browse/INFRA-19691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012638#comment-17012638
> > ]
> >
> > Sebb commented on INFRA-19691:
> > ------------------------------
> >
> > The content-type will depend on the mail client.
> >
> > I just tried with GMail, and it sent the file test.txt as
> > Content-Type: text/plain; charset="US-ASCII"; name="test.txt"
> >
> > whereas test.patch resulted in:
> > Content-Type: application/octet-stream; name="test.patch"
> >
> > ==
> >
> > However, it's usually not ideal to send patches to mailing lists.
> > Better to use an issue tracking system."
> >
> > Then he just Closed the ticket with the resolution: Information Provided
> >
> > BR,
> >
> > Alan
>
> So, will this be fixed or not? Tools are there to support users and
> throwing away patches because the tools are sulky doesn't sound like
> very support-y to me?
>
> Regards
>
> DAVE
>
Our workflow document already instructs users to send their patches with a
.txt extension because of this issue.
I just noticed that the git command given there doesn't correspond to that.
I will fix that when I get to my computer soon. (I use 'git format-patch
master --stdout > your_file_name_here.txt'; I don't know if there's another
way that requires less typing.)
That's all we can do on our end. It would take an act of Infra to change
that.
Nathan
Re: Sending .patch
Posted by Dave Marples <da...@marples.net>.
On 10/01/2020 09:58, Alan Carvalho de Assis wrote:
> Hi Everyone,
>
> As told I opened an Infra ticket to fix sending .patch to dev@ list.
>
> That was the response I received:
>
> " [ https://issues.apache.org/jira/browse/INFRA-19691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012638#comment-17012638
> ]
>
> Sebb commented on INFRA-19691:
> ------------------------------
>
> The content-type will depend on the mail client.
>
> I just tried with GMail, and it sent the file test.txt as
> Content-Type: text/plain; charset="US-ASCII"; name="test.txt"
>
> whereas test.patch resulted in:
> Content-Type: application/octet-stream; name="test.patch"
>
> ==
>
> However, it's usually not ideal to send patches to mailing lists.
> Better to use an issue tracking system."
>
> Then he just Closed the ticket with the resolution: Information Provided
>
> BR,
>
> Alan
So, will this be fixed or not? Tools are there to support users and
throwing away patches because the tools are sulky doesn't sound like
very support-y to me?
Regards
DAVE