[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts

["Francois Saint-Jacques (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286006#comment-14286006 ] 

Francois Saint-Jacques commented on KAFKA-1889:
-----------------------------------------------

I have multiple other comments on the scripts that I didn't address and might be worth talking.

1. There seems to be many way to pass option to kafka-run-class.sh, either by arguments (-daemon|-loggc|...) or by environment variables (KAFKA_JMX_OPTS|KAFKA_OPTS|KAFKA_HEAP_OPTS|...). This is inconsistent and needs to be addressed.
2. Scripts shouldn't bother daemonizing, leave this to packagers, just make sure you exec correctly.
3. The defaults are not production ready for servers:
 -gc log shouldn't be enabled by default
 -kafka-request.log to TRACE, this is a silent disk killer on busy cluster
 - never do this in non-init script, should be left to packagers: if [ ! -d "${LOG_DIR}" ]; then mkdir -p "${LOG_DIR}"; fi

> Refactor shell wrapper scripts
> ------------------------------
>
>                 Key: KAFKA-1889
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1889
>             Project: Kafka
>          Issue Type: Improvement
>          Components: packaging
>            Reporter: Francois Saint-Jacques
>            Assignee: Francois Saint-Jacques
>            Priority: Minor
>         Attachments: refactor-scripts-v1.patch
>
>
> Shell scripts in bin/ need love.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)