[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #292: chore(dev/release): create source archive on GitHub Actions

[GitBox <gi...@apache.org>]

lidavidm commented on code in PR #292:
URL: https://github.com/apache/arrow-adbc/pull/292#discussion_r1058949154


##########
ci/linux-packages/debian/control:
##########
@@ -31,7 +31,7 @@ Build-Depends:
 Standards-Version: 4.5.0
 Homepage: https://arrow.apache.org/adbc/
 
-Package: libadbc-driver-manager100
+Package: libadbc-driver-manager001

Review Comment:
   I guess the version bumping script needs to do this as well for the future?



##########
dev/release/01-prepare.sh:
##########
@@ -21,17 +21,21 @@ set -ue
 
 SOURCE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
-if [ "$#" -ne 3 ]; then
-  echo "Usage: $0 <version> <next_version> <rc-num>"
+if [ "$#" -ne 4 ]; then
+  echo "Usage: $0 <arrow-dir> <version> <next_version> <rc-num>"
+  echo "Usage: $0 ../arrow 0.1.0 1.0.0 0"
   exit 1
 fi
 
 . $SOURCE_DIR/utils-prepare.sh
 
-version=$1
-next_version=$2
+arrow_dir=$1
+version=$2
+next_version=$3
 next_version_snapshot="${next_version}-SNAPSHOT"
-rc_number=$3
+rc_number=$4
+
+export ARROW_SOURCE="$(cd "${arrow_dir}" && pwd)"

Review Comment:
   Is this used?



##########
.github/workflows/packaging.yml:
##########
@@ -114,7 +192,12 @@ jobs:
       - name: Build and test
         shell: bash
         run: |
-          docker-compose run java-dist
+          pushd adbc/
+          docker-compose run \
+            -e SETUPTOOLS_SCM_PRETEND_VERSION=${VERSION} \

Review Comment:
   Similarly I don't think this affects Java at all



##########
ci/linux-packages/debian/control:
##########
@@ -31,7 +31,7 @@ Build-Depends:
 Standards-Version: 4.5.0
 Homepage: https://arrow.apache.org/adbc/
 
-Package: libadbc-driver-manager100
+Package: libadbc-driver-manager001

Review Comment:
   Ah, it's added below.



##########
.github/workflows/packaging.yml:
##########
@@ -75,12 +141,18 @@ jobs:
       - name: Build and test
         shell: bash
         run: |
-          docker-compose run docs
+          pushd adbc
+          docker-compose run \
+            -e SETUPTOOLS_SCM_PRETEND_VERSION=${VERSION} \

Review Comment:
   I'll follow up and make sure this actually makes it into the docs (the Sphinx config tries its best to _not_ assume that any Python modules are installed)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org