[GitHub] [airflow] uranusjr commented on a diff in pull request #31960: Refactor Eks Create Cluster Operator code

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #31960:
URL: https://github.com/apache/airflow/pull/31960#discussion_r1233630838


##########
airflow/providers/amazon/aws/operators/eks.py:
##########
@@ -59,7 +59,55 @@
 FARGATE_FULL_NAME = "AWS Fargate profiles"
 
 
-class EksCreateClusterOperator(BaseOperator):
+class BaseEksCreateOperator(BaseOperator):
+    """
+    Base class for EKS Operators that create cluster resources. This includes
+    EksCreateClusterOperator, EksCreateNodeGroupOperator and EksCreateFargateProfileOperator.
+
+    """

Review Comment:
   ```suggestion
       """Base class for EKS Operators that create cluster resources.
   
       This includes EksCreateClusterOperator, EksCreateNodeGroupOperator and
       EksCreateFargateProfileOperator.
       """
   ```
   
   I’m not sure we should have the second line though. The list of classes doesn’t really add much useful information for maintenance, and is very easy to get stale.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org