You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "tedyu (via GitHub)" <gi...@apache.org> on 2024/09/17 12:08:32 UTC

Re: [PR] [MINOR] Avoid sorting in validateAndMaybeEvolveStateSchema [spark]

tedyu commented on PR #48116:
URL: https://github.com/apache/spark/pull/48116#issuecomment-2355538099

   bq. building a Set is not for free.
   
   Sorting is an O(N log N) operation while building Set is linear in complexity.
   
   bq. The Set removes duplicates 
   
   In this code, there is no duplicate in the schema.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org