You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Lars George (JIRA)" <ji...@apache.org> on 2011/02/09 09:13:57 UTC
[jira] Created: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
[HBase] Change test properties and template to be less provider bound
---------------------------------------------------------------------
Key: WHIRR-233
URL: https://issues.apache.org/jira/browse/WHIRR-233
Project: Whirr
Issue Type: Improvement
Components: service/hbase
Affects Versions: 0.4.0
Reporter: Lars George
Assignee: Lars George
Priority: Trivial
Fix For: 0.4.0
I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
{code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005123#comment-13005123 ]
Tom White commented on WHIRR-233:
---------------------------------
This kind of strategy can be implemented in HBaseTemplateBuilderStrategy - no changes are needed to jclouds. This way there are sensible defaults, which can be overridden by expert users by specifying properties.
> [HBase] Change test properties and template to be less provider bound
> ---------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.5.0
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-233) Change test properties to be less
provider bound and improve TemplateBuilder defaults
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-233:
------------------------------
Attachment: WHIRR-233.patch
Fixed patch: removed some unused imports and expanded the star import.
> Change test properties to be less provider bound and improve TemplateBuilder defaults
> -------------------------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: core, service/hadoop, service/hbase
> Reporter: Lars George
> Assignee: Andrei Savu
> Priority: Blocker
> Fix For: 0.4.0
>
> Attachments: WHIRR-233-min-RAM.patch, WHIRR-233.patch, WHIRR-233.patch
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-233:
------------------------------
Fix Version/s: (was: 0.4.0)
> [HBase] Change test properties and template to be less provider bound
> ---------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.4.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007970#comment-13007970 ]
Andrei Savu commented on WHIRR-233:
-----------------------------------
Sounds like a good idea. I will give it a try.
> [HBase] Change test properties and template to be less provider bound
> ---------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Reporter: Lars George
> Assignee: Lars George
> Priority: Blocker
> Fix For: 0.5.0
>
> Attachments: WHIRR-233.patch
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008059#comment-13008059 ]
Tom White commented on WHIRR-233:
---------------------------------
+1
Nit: this introduces a star import, which we should avoid.
> [HBase] Change test properties and template to be less provider bound
> ---------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Reporter: Lars George
> Assignee: Lars George
> Priority: Blocker
> Fix For: 0.5.0
>
> Attachments: WHIRR-233-min-RAM.patch, WHIRR-233.patch
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008013#comment-13008013 ]
Andrei Savu commented on WHIRR-233:
-----------------------------------
Tom, we can push this in the 0.4.0 release if you think it's good enough. I will rebuild the artefacts for 0.4.0 in a few hours and restart the vote. Let me know what you think.
> [HBase] Change test properties and template to be less provider bound
> ---------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Reporter: Lars George
> Assignee: Lars George
> Priority: Blocker
> Fix For: 0.5.0
>
> Attachments: WHIRR-233-min-RAM.patch, WHIRR-233.patch
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007515#comment-13007515 ]
Andrei Savu commented on WHIRR-233:
-----------------------------------
I believe we should do this for all services not only for HBase.
> [HBase] Change test properties and template to be less provider bound
> ---------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Reporter: Lars George
> Assignee: Lars George
> Priority: Blocker
> Fix For: 0.5.0
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-233:
------------------------------
Affects Version/s: (was: 0.4.0)
Fix Version/s: 0.5.0
> [HBase] Change test properties and template to be less provider bound
> ---------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.5.0
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-233) Change test properties to be less
provider bound and improve TemplateBuilder defaults
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-233:
------------------------------
Component/s: service/hadoop
core
Fix Version/s: (was: 0.5.0)
0.4.0
Assignee: Andrei Savu (was: Lars George)
Summary: Change test properties to be less provider bound and improve TemplateBuilder defaults (was: [HBase] Change test properties and template to be less provider bound)
Updated issue description.
> Change test properties to be less provider bound and improve TemplateBuilder defaults
> -------------------------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: core, service/hadoop, service/hbase
> Reporter: Lars George
> Assignee: Andrei Savu
> Priority: Blocker
> Fix For: 0.4.0
>
> Attachments: WHIRR-233-min-RAM.patch, WHIRR-233.patch
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated WHIRR-233:
----------------------------
Priority: Blocker (was: Trivial)
Marking as a blocker (for 0.5.0) since HBase integration tests will always fail on cloudservers until this is fixed.
> [HBase] Change test properties and template to be less provider bound
> ---------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Reporter: Lars George
> Assignee: Lars George
> Priority: Blocker
> Fix For: 0.5.0
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008037#comment-13008037 ]
Adrian Cole commented on WHIRR-233:
-----------------------------------
+1
It solves the issue of having test properties being less provider bound.
As another issue, we should calculate the requirements of the machine based on the roles present and their minimums. Ex. if a host is running 4 roles, it will need more ram, and probably more cores, dependent on the needs of those roles.
> [HBase] Change test properties and template to be less provider bound
> ---------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Reporter: Lars George
> Assignee: Lars George
> Priority: Blocker
> Fix For: 0.5.0
>
> Attachments: WHIRR-233-min-RAM.patch, WHIRR-233.patch
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992409#comment-12992409 ]
Lars George commented on WHIRR-233:
-----------------------------------
See http://code.google.com/p/jclouds/issues/detail?id=469 for ideas on implementing this very flexible.
> [HBase] Change test properties and template to be less provider bound
> ---------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.4.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.4.0
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-233:
------------------------------
Attachment: WHIRR-233-min-RAM.patch
This patch adds a new ClusterSpec option that allows the user to specify the minimum amount of memory needed. I don't think this is really required; sounds more like an optimisation for testing. I believe in practice an user would specify a hardware-id if he wants a larger or smaller instance.
> [HBase] Change test properties and template to be less provider bound
> ---------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Reporter: Lars George
> Assignee: Lars George
> Priority: Blocker
> Fix For: 0.5.0
>
> Attachments: WHIRR-233-min-RAM.patch, WHIRR-233.patch
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WHIRR-233) Change test properties to be less
provider bound and improve TemplateBuilder defaults
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu resolved WHIRR-233.
-------------------------------
Resolution: Fixed
I've just committed this. Thanks guys for review!
> Change test properties to be less provider bound and improve TemplateBuilder defaults
> -------------------------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: core, service/hadoop, service/hbase
> Reporter: Lars George
> Assignee: Andrei Savu
> Priority: Blocker
> Fix For: 0.4.0
>
> Attachments: WHIRR-233-min-RAM.patch, WHIRR-233.patch, WHIRR-233.patch
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007960#comment-13007960 ]
Adrian Cole commented on WHIRR-233:
-----------------------------------
I like the approach. However, it uses more expensive hardware for zookeeper and cassandra. How about if we expose a minRam and minCores property on properties per role?
> [HBase] Change test properties and template to be less provider bound
> ---------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Reporter: Lars George
> Assignee: Lars George
> Priority: Blocker
> Fix For: 0.5.0
>
> Attachments: WHIRR-233.patch
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-233) [HBase] Change test properties and
template to be less provider bound
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-233:
------------------------------
Attachment: WHIRR-233.patch
Global improved defaults for TemplateBuilder. All integration tests pass on aws-ec2.
> [HBase] Change test properties and template to be less provider bound
> ---------------------------------------------------------------------
>
> Key: WHIRR-233
> URL: https://issues.apache.org/jira/browse/WHIRR-233
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Reporter: Lars George
> Assignee: Lars George
> Priority: Blocker
> Fix For: 0.5.0
>
> Attachments: WHIRR-233.patch
>
>
> I talked to Adrian on IRC and concluded that we need to remove the location and instance ID from the test properties but add to the Template class something like:
> {code}minRam(someAmount).os64Bit(true).osFamily(OsFamily.UBUNTU).osVersionMatches("10.04"){code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira