You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/12 02:22:21 UTC
[GitHub] [druid] codecov-io commented on issue #9490: Fix NPE when using
IndexedTable and all left rows are filtered out
codecov-io commented on issue #9490: Fix NPE when using IndexedTable and all left rows are filtered out
URL: https://github.com/apache/druid/pull/9490#issuecomment-597973503
# [Codecov](https://codecov.io/gh/apache/druid/pull/9490?src=pr&el=h1) Report
> Merging [#9490](https://codecov.io/gh/apache/druid/pull/9490?src=pr&el=desc) into [master](https://codecov.io/gh/apache/druid/commit/7401bb3f9315bf0622b6e0fe7c7fd855d1c65052?src=pr&el=desc) will **increase** coverage by `0.97%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/druid/pull/9490/graphs/tree.svg?width=650&token=hn9gC9NXg0&height=150&src=pr)](https://codecov.io/gh/apache/druid/pull/9490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9490 +/- ##
============================================
+ Coverage 63.56% 64.53% +0.97%
- Complexity 23489 23561 +72
============================================
Files 3040 2932 -108
Lines 125895 119863 -6032
Branches 17410 16046 -1364
============================================
- Hits 80026 77359 -2667
+ Misses 38673 35522 -3151
+ Partials 7196 6982 -214
```
| [Impacted Files](https://codecov.io/gh/apache/druid/pull/9490?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...id/segment/join/table/IndexedTableJoinMatcher.java](https://codecov.io/gh/apache/druid/pull/9490/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvc2VnbWVudC9qb2luL3RhYmxlL0luZGV4ZWRUYWJsZUpvaW5NYXRjaGVyLmphdmE=) | `87.23% <100%> (+0.09%)` | `27 <0> (ø)` | :arrow_down: |
| [...main/java/org/apache/druid/guice/DruidBinders.java](https://codecov.io/gh/apache/druid/pull/9490/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kcnVpZC9ndWljZS9EcnVpZEJpbmRlcnMuamF2YQ==) | `33.33% <0%> (-8.34%)` | `3% <0%> (ø)` | |
| [...org/apache/druid/segment/realtime/FireHydrant.java](https://codecov.io/gh/apache/druid/pull/9490/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kcnVpZC9zZWdtZW50L3JlYWx0aW1lL0ZpcmVIeWRyYW50LmphdmE=) | `58.33% <0%> (-8.34%)` | `14% <0%> (-1%)` | |
| [...g/apache/druid/query/FluentQueryRunnerBuilder.java](https://codecov.io/gh/apache/druid/pull/9490/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvcXVlcnkvRmx1ZW50UXVlcnlSdW5uZXJCdWlsZGVyLmphdmE=) | `75% <0%> (-5%)` | `2% <0%> (ø)` | |
| [.../server/lookup/namespace/cache/CacheScheduler.java](https://codecov.io/gh/apache/druid/pull/9490/diff?src=pr&el=tree#diff-ZXh0ZW5zaW9ucy1jb3JlL2xvb2t1cHMtY2FjaGVkLWdsb2JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvc2VydmVyL2xvb2t1cC9uYW1lc3BhY2UvY2FjaGUvQ2FjaGVTY2hlZHVsZXIuamF2YQ==) | `75.56% <0%> (-2.85%)` | `9% <0%> (ø)` | |
| [.../java/org/apache/druid/query/InlineDataSource.java](https://codecov.io/gh/apache/druid/pull/9490/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvcXVlcnkvSW5saW5lRGF0YVNvdXJjZS5qYXZh) | `85.1% <0%> (-1.57%)` | `27% <0%> (ø)` | |
| [...query/groupby/epinephelinae/ConcurrentGrouper.java](https://codecov.io/gh/apache/druid/pull/9490/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvcXVlcnkvZ3JvdXBieS9lcGluZXBoZWxpbmFlL0NvbmN1cnJlbnRHcm91cGVyLmphdmE=) | `70.8% <0%> (-0.73%)` | `28% <0%> (-1%)` | |
| [...rdinatorBasicAuthorizerMetadataStorageUpdater.java](https://codecov.io/gh/apache/druid/pull/9490/diff?src=pr&el=tree#diff-ZXh0ZW5zaW9ucy1jb3JlL2RydWlkLWJhc2ljLXNlY3VyaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kcnVpZC9zZWN1cml0eS9iYXNpYy9hdXRob3JpemF0aW9uL2RiL3VwZGF0ZXIvQ29vcmRpbmF0b3JCYXNpY0F1dGhvcml6ZXJNZXRhZGF0YVN0b3JhZ2VVcGRhdGVyLmphdmE=) | `63.32% <0%> (-0.41%)` | `76% <0%> (-1%)` | |
| [...java/org/apache/druid/query/groupby/ResultRow.java](https://codecov.io/gh/apache/druid/pull/9490/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvcXVlcnkvZ3JvdXBieS9SZXN1bHRSb3cuamF2YQ==) | `87.23% <0%> (-0.27%)` | `19% <0%> (-1%)` | |
| [.../apache/druid/server/ClientQuerySegmentWalker.java](https://codecov.io/gh/apache/druid/pull/9490/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kcnVpZC9zZXJ2ZXIvQ2xpZW50UXVlcnlTZWdtZW50V2Fsa2VyLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [139 more](https://codecov.io/gh/apache/druid/pull/9490/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/druid/pull/9490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/druid/pull/9490?src=pr&el=footer). Last update [7401bb3...7780ce4](https://codecov.io/gh/apache/druid/pull/9490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org