[GitHub] [incubator-pekko-http] raboof commented on a diff in pull request #150: Scala 3 support

["raboof (via GitHub)" <gi...@apache.org>]

raboof commented on code in PR #150:
URL: https://github.com/apache/incubator-pekko-http/pull/150#discussion_r1206609146


##########
http-core/src/main/scala/org/apache/pekko/http/impl/model/parser/SimpleHeaders.scala:
##########
@@ -111,14 +112,14 @@ private[parser] trait SimpleHeaders { this: Parser with CommonRules with CommonA
 
   // http://tools.ietf.org/html/rfc7233#section-4.2
   def `content-range` = rule {
-    (`byte-content-range` | `other-content-range`) ~ EOI ~> (`Content-Range`(_, _))
+    `byte-content-range` ~ EOI ~> (`Content-Range`(_, _)) | `other-content-range` ~ EOI ~> (`Content-Range`(_, _))

Review Comment:
   this change was part of 0a979b87f0 and indeed back then (on scala 3.1.3) was required to compile. The old syntax seems to work again on scala 3.2.2 and 3.3.0, though, so this change could be reverted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org