You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/06/23 05:53:51 UTC

Review Request 22856: Removed the wait in StartMaster() for the master to get elected before returning because it's no longer necessary.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22856/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos-git


Description
-------

- Cluster::Masters::start now waits for the master to be recovered, which happens only after it's elected.


Diffs
-----

  src/tests/cluster.hpp 1c96ee7d27d1f2f277bc4617f9e17092460d7191 
  src/tests/mesos.hpp 0b9b2f9bfc0def5d65fb571816d62d52f3d0cda4 
  src/tests/mesos.cpp 10374201121e376f3a1de33278dfd0ea92edd7b2 

Diff: https://reviews.apache.org/r/22856/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Re: Review Request 22856: Removed the wait in StartMaster() for the master to get elected before returning because it's no longer necessary.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22856/#review46418
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On June 23, 2014, 3:53 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22856/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 3:53 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> - Cluster::Masters::start now waits for the master to be recovered, which happens only after it's elected.
> 
> 
> Diffs
> -----
> 
>   src/tests/cluster.hpp 1c96ee7d27d1f2f277bc4617f9e17092460d7191 
>   src/tests/mesos.hpp 0b9b2f9bfc0def5d65fb571816d62d52f3d0cda4 
>   src/tests/mesos.cpp 10374201121e376f3a1de33278dfd0ea92edd7b2 
> 
> Diff: https://reviews.apache.org/r/22856/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>