You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/29 10:50:40 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request, #20912: [WIP] Drill modal apply all of the filters
zhaoyongjie opened a new pull request, #20912:
URL: https://github.com/apache/superset/pull/20912
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR follow-up [PR](https://github.com/apache/superset/pull/20728) from Cody, the new commit has only one purpose, to apply all the `column filters`(time filter/adhoc filter/native filter/....) to the dill detail query but remove all `having filter`.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie closed pull request #20912: [WIP] Drill modal apply all of the filters
Posted by GitBox <gi...@apache.org>.
zhaoyongjie closed pull request #20912: [WIP] Drill modal apply all of the filters
URL: https://github.com/apache/superset/pull/20912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #20912: [WIP] Drill modal apply all of the filters
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #20912:
URL: https://github.com/apache/superset/pull/20912#issuecomment-1199386019
> I noticed that when passing a different `drillFilters` param to `DrillDetailPane`, the query isn't updating.
Thanks @michael-s-molina I will update these on the cody's PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #20912: [WIP] Drill modal apply all of the filters
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #20912:
URL: https://github.com/apache/superset/pull/20912#issuecomment-1199387981
the commit has cherry-pick to cody's [PR](https://github.com/apache/superset/pull/20728)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #20912: [WIP] Drill modal apply all of the filters
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #20912:
URL: https://github.com/apache/superset/pull/20912#issuecomment-1199279563
Thank you for the PR @zhaoyongjie!
I noticed that when passing a different `drillFilters` param to `DrillDetailPane`, the query isn't updating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org