You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by xubo245 <gi...@git.apache.org> on 2018/01/11 03:28:16 UTC
[GitHub] spark pull request #20228: [SPARK-23036] Add withGlobalTempView for testing ...
GitHub user xubo245 opened a pull request:
https://github.com/apache/spark/pull/20228
[SPARK-23036] Add withGlobalTempView for testing and correct some roper with view related method usage
## What changes were proposed in this pull request?
Add withGlobalTempView when create global temp view, like withTempView and withView.
And correct some improper usage.
## How was this patch tested?
no new test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/spark DropTempView
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20228
----
commit fffd109e8c084f9a4d63840bf761364f1ede5dc9
Author: xubo245 <60...@...>
Date: 2018-01-11T03:25:17Z
[SPARK-23036] Add withGlobalTempView for testing and correct some improper with view related method usage
Add withGlobalTempView when create global temp view, like withTempView and withView.
And correct some improper usage.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036] Add withGlobalTempView for testing and cor...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20228
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL] Add withGlobalTempView for testing an...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20228
**[Test build #86041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86041/testReport)** for PR 20228 at commit [`198f1ff`](https://github.com/apache/spark/commit/198f1ff54e88bf507692cdbc04669b5ee44f1678).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20228: [SPARK-23036] Add withGlobalTempView for testing ...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20228#discussion_r160866670
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala ---
@@ -140,8 +140,8 @@ class GlobalTempViewSuite extends QueryTest with SharedSQLContext {
assert(spark.catalog.listTables(globalTempDB).collect().toSeq.map(_.name) == Seq("v1", "v2"))
} finally {
- spark.catalog.dropTempView("v1")
- spark.catalog.dropGlobalTempView("v2")
+ spark.catalog.dropGlobalTempView("v1")
+ spark.catalog.dropTempView("v2")
--- End diff --
Hi, @xubo245 .
Could you split the bug and new improvement into two separate PR?
Then, your PR will get reviews more easily.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20228
Thanks! Merged to master/2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView f...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20228#discussion_r161378537
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala ---
@@ -36,7 +36,7 @@ class GlobalTempViewSuite extends QueryTest with SharedSQLContext {
test("basic semantic") {
val expectedErrorMsg = "not found"
- try {
+ withGlobalTempView("src") {
--- End diff --
This is wrong. Do you know why?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20228
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86041/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL] Add withGlobalTempView for testing an...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85976/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL] Add withGlobalTempView for testing an...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20228
@xubo245 This is only for TEST? Then, add the tag [TEST] in your title too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20228
Retest this please.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20228
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL] Add withGlobalTempView for testing an...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20228
**[Test build #85976 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85976/testReport)** for PR 20228 at commit [`fffd109`](https://github.com/apache/spark/commit/fffd109e8c084f9a4d63840bf761364f1ede5dc9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20228
**[Test build #86052 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86052/testReport)** for PR 20228 at commit [`198f1ff`](https://github.com/apache/spark/commit/198f1ff54e88bf507692cdbc04669b5ee44f1678).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036] Add withGlobalTempView for testing and cor...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20228
BTW, please put '[SQL]' into your title.
Then, your PR will be listed under SQL category here.
- https://spark-prs.appspot.com/open-prs
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL] Add withGlobalTempView for testing an...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20228
**[Test build #85976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85976/testReport)** for PR 20228 at commit [`fffd109`](https://github.com/apache/spark/commit/fffd109e8c084f9a4d63840bf761364f1ede5dc9).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView f...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20228#discussion_r161253370
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala ---
@@ -140,8 +140,8 @@ class GlobalTempViewSuite extends QueryTest with SharedSQLContext {
assert(spark.catalog.listTables(globalTempDB).collect().toSeq.map(_.name) == Seq("v1", "v2"))
} finally {
- spark.catalog.dropTempView("v1")
- spark.catalog.dropGlobalTempView("v2")
+ spark.catalog.dropGlobalTempView("v1")
+ spark.catalog.dropTempView("v2")
--- End diff --
Ok, done. Please review: https://github.com/apache/spark/pull/20250
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86052/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/spark/pull/20228
@gatorsmile Sure. This is only for TEST. Done , I put '[SQL]' into title too
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20228
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20228
**[Test build #86041 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86041/testReport)** for PR 20228 at commit [`198f1ff`](https://github.com/apache/spark/commit/198f1ff54e88bf507692cdbc04669b5ee44f1678).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL] Add withGlobalTempView for testing an...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20228
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL] Add withGlobalTempView for testing an...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20228
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20228
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20228
**[Test build #86052 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86052/testReport)** for PR 20228 at commit [`198f1ff`](https://github.com/apache/spark/commit/198f1ff54e88bf507692cdbc04669b5ee44f1678).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/spark/pull/20228
ok, done, I put '[SQL]' into title. @dongjoon-hyun
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20228: [SPARK-23036][SQL][TEST] Add withGlobalTempView for test...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20228
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org