You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/22 08:38:16 UTC
[GitHub] [airflow] Aakcht opened a new pull request #13828: Fix kerberos envs for workers in helm chart
Aakcht opened a new pull request #13828:
URL: https://github.com/apache/airflow/pull/13828
When worker log persistence is enabled in helm chart, KRB5_CONFIG and KRB5CCNAME envs do not get into worker container because worker-gc container is rendered before it.
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#issuecomment-766352321
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#issuecomment-766396560
Everything looks fine so I'm merging it now. Thanks for this fix. I will update one environment with Kerberos soon, so this change helped me a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#issuecomment-765237320
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13828:
URL: https://github.com/apache/airflow/pull/13828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#issuecomment-766396560
Everything looks fine so I'm merging it now. Thanks for this fix. I will update soon one environment with Kerberos, so this change helped me a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Aakcht commented on a change in pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
Aakcht commented on a change in pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#discussion_r563289590
##########
File path: chart/templates/workers/worker-deployment.yaml
##########
@@ -158,6 +158,12 @@ spec:
env:
{{- include "custom_airflow_environment" . | indent 10 }}
{{- include "standard_airflow_environment" . | indent 10 }}
+ {{- if .Values.workers.kerberosSidecar.enabled }}
+ - name: KRB5_CONFIG
+ value: {{ .Values.kerberos.configPath | quote }}
+ - name: KRB5CCNAME
+ value: {{ include "kerberos_ccache_path" . | quote }}
+ {{- end }}
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Aakcht commented on pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
Aakcht commented on pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#issuecomment-766344624
@mik-laj I've added a test, please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#discussion_r563262259
##########
File path: chart/templates/workers/worker-deployment.yaml
##########
@@ -158,6 +158,12 @@ spec:
env:
{{- include "custom_airflow_environment" . | indent 10 }}
{{- include "standard_airflow_environment" . | indent 10 }}
+ {{- if .Values.workers.kerberosSidecar.enabled }}
+ - name: KRB5_CONFIG
+ value: {{ .Values.kerberos.configPath | quote }}
+ - name: KRB5CCNAME
+ value: {{ include "kerberos_ccache_path" . | quote }}
+ {{- end }}
Review comment:
```suggestion
{{- if .Values.workers.kerberosSidecar.enabled }}
- name: KRB5_CONFIG
value: {{ .Values.kerberos.configPath | quote }}
- name: KRB5CCNAME
value: {{ include "kerberos_ccache_path" . | quote }}
{{- end }}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#issuecomment-766316273
Can you [add tests](https://github.com/apache/airflow/blob/master/TESTING.rst#helm-unit-tests) to avoid regression?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Aakcht commented on pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
Aakcht commented on pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#issuecomment-766389701
Not sure what is the issue with the CI, the error is different after rebasing and don't seem to be related to my change. Should I try triggering the CI again or will it be ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#issuecomment-766396560
Everything looks fine so I'm merging it now. Thanks for this fix. I will update soon one environment with Kerberos, so this change helped me a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13828:
URL: https://github.com/apache/airflow/pull/13828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#issuecomment-766395987
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Aakcht commented on pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
Aakcht commented on pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#issuecomment-766389701
Not sure what is the issue with the CI, the error is different after rebasing and don't seem to be related to my change. Should I try triggering the CI again or will it be ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#issuecomment-766395987
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #13828: Fix kerberos envs for workers in helm chart
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #13828:
URL: https://github.com/apache/airflow/pull/13828#issuecomment-766396560
Everything looks fine so I'm merging it now. Thanks for this fix. I will update one environment with Kerberos soon, so this change helped me a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org