[GitHub] [iceberg] rdblue commented on a diff in pull request #6513: API,Core: Support Conditional Commits

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #6513:
URL: https://github.com/apache/iceberg/pull/6513#discussion_r1129872213


##########
core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java:
##########
@@ -165,4 +165,9 @@ private Expression dataConflictDetectionFilter() {
       return Expressions.alwaysTrue();
     }
   }
+
+  @Override
+  protected SnapshotUpdate<OverwriteFiles> returnThis() {

Review Comment:
   I don't think this is a good idea. This should use the existing `self()` method and use a similar signature as the others configuration methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org