You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@flink.apache.org by Vinay Patil <vi...@gmail.com> on 2020/06/10 12:17:25 UTC

Timer metric in Flink

Hi,

As timer metric is not provided out of the box, can I create a new
MetricGroup by implementing this interface and add timer capability, this
will be similar to Histogram wrapper Flink has provided. If yes, I can
create a wrapper like

`public TimerWrapper implements Timer` , in this case will also have to
create Timer interface and add it to the metric group.

Is this possible?

I want to have a timer to check Hbase lookup time.

Regards,
Vinay Patil

Re: Timer metric in Flink

Posted by Chesnay Schepler <ch...@apache.org>.
There are no immediate plans, mostly because timers are fairly expensive 
and represent an easy trap to trashing performance of invalidating 
benchmark results.

On 11/06/2020 13:11, Vinay Patil wrote:
> Ohh Okay, basically implement the Gauge and add timer functionality to 
> it for now.
>
> Is there a plan or JIRA ticket to add Timer metric in future release, 
> I think it is good to have
>
> Regards,
> Vinay Patil
>
>
> On Wed, Jun 10, 2020 at 5:55 PM Chesnay Schepler <chesnay@apache.org 
> <ma...@apache.org>> wrote:
>
>     You cannot add custom metric types, just implementations of the
>     existing ones. Your timer(wrapper) will have to implement Gauge or
>     Histogram.
>
>     On 10/06/2020 14:17, Vinay Patil wrote:
>>     Hi,
>>
>>     As timer metric is not provided out of the box, can I create a
>>     new MetricGroup by implementing this interface and add timer
>>     capability, this will be similar to Histogram wrapper Flink has
>>     provided. If yes, I can create a wrapper like
>>
>>     `public TimerWrapper implements Timer` , in this case will also
>>     have to create Timer interface and add it to the metric group.
>>
>>     Is this possible?
>>
>>     I want to have a timer to check Hbase lookup time.
>>
>>     Regards,
>>     Vinay Patil
>
>


Re: Timer metric in Flink

Posted by Vinay Patil <vi...@gmail.com>.
Ohh Okay, basically implement the Gauge and add timer functionality to it
for now.

Is there a plan or JIRA ticket to add Timer metric in future release, I
think it is good to have

Regards,
Vinay Patil


On Wed, Jun 10, 2020 at 5:55 PM Chesnay Schepler <ch...@apache.org> wrote:

> You cannot add custom metric types, just implementations of the existing
> ones. Your timer(wrapper) will have to implement Gauge or Histogram.
>
> On 10/06/2020 14:17, Vinay Patil wrote:
>
> Hi,
>
> As timer metric is not provided out of the box, can I create a new
> MetricGroup by implementing this interface and add timer capability, this
> will be similar to Histogram wrapper Flink has provided. If yes, I can
> create a wrapper like
>
> `public TimerWrapper implements Timer` , in this case will also have to
> create Timer interface and add it to the metric group.
>
> Is this possible?
>
> I want to have a timer to check Hbase lookup time.
>
> Regards,
> Vinay Patil
>
>
>

Re: Timer metric in Flink

Posted by Chesnay Schepler <ch...@apache.org>.
You cannot add custom metric types, just implementations of the existing 
ones. Your timer(wrapper) will have to implement Gauge or Histogram.

On 10/06/2020 14:17, Vinay Patil wrote:
> Hi,
>
> As timer metric is not provided out of the box, can I create a new 
> MetricGroup by implementing this interface and add timer capability, 
> this will be similar to Histogram wrapper Flink has provided. If yes, 
> I can create a wrapper like
>
> `public TimerWrapper implements Timer` , in this case will also have 
> to create Timer interface and add it to the metric group.
>
> Is this possible?
>
> I want to have a timer to check Hbase lookup time.
>
> Regards,
> Vinay Patil