[GitHub] [geode] agingade commented on a change in pull request #6659: GEODE-9404: Do not log error message if sender is not configured.

[GitBox <gi...@apache.org>]

agingade commented on a change in pull request #6659:
URL: https://github.com/apache/geode/pull/6659#discussion_r662567651



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/TXLastEventInTransactionUtils.java
##########
@@ -77,11 +78,7 @@ private static boolean checkNoSendersGroupTransactionEvents(List<EntryEventImpl>
       Cache cache) throws ServiceConfigurationError {
     for (String senderId : getSenderIdsForEvents(callbacks)) {
       GatewaySender sender = cache.getGatewaySender(senderId);
-      if (sender == null) {
-        logger.error("No sender found for {}", senderId);
-        throw new ServiceConfigurationError("No information for senderId: " + senderId);
-      }
-      if (sender.mustGroupTransactionEvents()) {
+      if (sender != null && sender.mustGroupTransactionEvents()) {

Review comment:
       The "ServiceConfigurationError" is thrown in "getLastTransactionEvent" that can also be removed by returning null; as done here...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org