You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "linghengqian (via GitHub)" <gi...@apache.org> on 2024/11/18 09:03:20 UTC

[PR] Removes support for jdbcURL prefix of `jdbc:tc:shardingsphere0clickhouse:` [shardingsphere]

linghengqian opened a new pull request, #33707:
URL: https://github.com/apache/shardingsphere/pull/33707

   For #29052.
   
   Changes proposed in this pull request:
     - Removes support for jdbcURL prefix of `jdbc:tc:shardingsphere0clickhouse:`. Due to the ongoing disputes at https://github.com/testcontainers/testcontainers-java/issues/8736 and https://github.com/testcontainers/testcontainers-java/pull/8738, it is not reasonable to continue to open holes on the side of shardingsphere.
     - Updates Row Value expression documentation. Previously the definition of SPI files was missing.
     - Updates sharding algorithm documentation. `Gy-MM` is not a valid Japanese calendar format.
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [x] I have made corresponding changes to the documentation.
   - [x] I have added corresponding unit tests for my changes.
   - [x] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Removes support for jdbcURL prefix of `jdbc:tc:shardingsphere0clickhouse:` [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #33707:
URL: https://github.com/apache/shardingsphere/pull/33707


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org