You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2016/07/22 00:02:08 UTC
Review Request 50316: add support to lucene's raw Directory
(RAMDirectory or NIOFSDirectory)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50316/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Barry Oglesby, and Dan Smith.
Bugs: GEODE-11
https://issues.apache.org/jira/browse/GEODE-11
Repository: geode
Description
-------
This alternative is NOT to refactor the current APIs' signature, so it passed many unused paramters.
Diffs
-----
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/IndexRepositoryFactory.java ae4b88b
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java af05e7d
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java 3cc713b
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerFactory.java PRE-CREATION
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/RawIndexRepositoryFactory.java PRE-CREATION
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/RawLuceneRepositoryManager.java PRE-CREATION
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/RawLuceneRepositoryManagerFactory.java PRE-CREATION
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java 0b70542
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/RepositoryManager.java 8f8d202
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java 6f38ff4
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java 67f318b
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java 2221a6d
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/RawLuceneRepositoryManagerJUnitTest.java PRE-CREATION
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 1f1d2c9
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java cd67413
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java 3155aaf
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/IndexRepositorySpy.java 0b66f55
Diff: https://reviews.apache.org/r/50316/diff/
Testing
-------
added junit test and all geode-lucene tests passed.
Thanks,
xiaojian zhou
Re: Review Request 50316: add support to lucene's raw Directory
(RAMDirectory or NIOFSDirectory)
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50316/#review143575
-----------------------------------------------------------
Ship it!
It might be nice to add some javadocs to the Raw... classes to indicate what they are for. In particular, it might be nice to document that they are really only for experimentation, since they won't work with things like bucket movement, HA, etc.
- Dan Smith
On July 22, 2016, 12:02 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50316/
> -----------------------------------------------------------
>
> (Updated July 22, 2016, 12:02 a.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, and Dan Smith.
>
>
> Bugs: GEODE-11
> https://issues.apache.org/jira/browse/GEODE-11
>
>
> Repository: geode
>
>
> Description
> -------
>
> This alternative is NOT to refactor the current APIs' signature, so it passed many unused paramters.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/IndexRepositoryFactory.java ae4b88b
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java af05e7d
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java 3cc713b
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerFactory.java PRE-CREATION
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/RawIndexRepositoryFactory.java PRE-CREATION
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/RawLuceneRepositoryManager.java PRE-CREATION
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/RawLuceneRepositoryManagerFactory.java PRE-CREATION
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java 0b70542
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/RepositoryManager.java 8f8d202
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java 6f38ff4
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java 67f318b
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java 2221a6d
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/RawLuceneRepositoryManagerJUnitTest.java PRE-CREATION
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 1f1d2c9
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java cd67413
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java 3155aaf
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/IndexRepositorySpy.java 0b66f55
>
> Diff: https://reviews.apache.org/r/50316/diff/
>
>
> Testing
> -------
>
> added junit test and all geode-lucene tests passed.
>
>
> Thanks,
>
> xiaojian zhou
>
>