You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/08/19 17:57:24 UTC
[GitHub] [solr] cpoerschke opened a new pull request #269: SOLR-13138: deprecate LegacyBM25SimilarityFactory
cpoerschke opened a new pull request #269:
URL: https://github.com/apache/solr/pull/269
As per https://github.com/apache/lucene/pull/247 `LegacyBM25Similarity` will be removed from Lucene 9.0 onwards.
Do we wish to formally mark `LegacyBM25SimilarityFactory` deprecated from Solr 8.10 onwards (assuming Solr 9.0 would remove it) or does the "Legacy" part of the name perhaps sort of imply deprecation enough already?
https://issues.apache.org/jira/browse/SOLR-13138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke merged pull request #269: SOLR-13138: deprecate LegacyBM25SimilarityFactory
Posted by GitBox <gi...@apache.org>.
cpoerschke merged pull request #269:
URL: https://github.com/apache/solr/pull/269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on pull request #269: SOLR-13138: deprecate LegacyBM25SimilarityFactory
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #269:
URL: https://github.com/apache/solr/pull/269#issuecomment-906586125
> I think it may make sense to deprecate it in Solr 8.10. Not because people use it in their client code and would be alerted by the annotation. But because RefGuide mentions it several places, and further links to the JavaDoc page for it.
Good catch about places mentioning, I've added a commit, did I find all the several places?
And any thoughts on a `solr/CHANGES.txt` entry being or not being useful here? I'm leaning towards "not needed" but not strongly so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #269: SOLR-13138: deprecate LegacyBM25SimilarityFactory
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #269:
URL: https://github.com/apache/solr/pull/269#issuecomment-905301302
I think it may make sense to deprecate it in Solr 8.10. Not because people use it in their client code and would be alerted by the annotation. But because RefGuide mentions it several places, and further links to the JavaDoc page for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #269: SOLR-13138: deprecate LegacyBM25SimilarityFactory
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #269:
URL: https://github.com/apache/solr/pull/269#issuecomment-906701981
Changes entry is your call. It’s more important to add it to major changes in 9.0 chapter in refguide, but doesn’t hurt with a changes entry either, perhaps someone actually read them 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on pull request #269: SOLR-13138: deprecate LegacyBM25SimilarityFactory
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #269:
URL: https://github.com/apache/solr/pull/269#issuecomment-907288205
> Changes entry is your call. It’s more important to add it to major changes in 9.0 chapter in refguide, but doesn’t hurt with a changes entry either, perhaps someone actually read them 😉
Yes, my plan was (and still is) to do the "major changes in 9.0" documentation as part of the removal of the class. But well, to help ensure it happens, might as well open the matching PR for that: https://github.com/apache/solr/pull/274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org