[jira] [Comment Edited] (FLINK-15523) ConfigConstants generally excluded from japicmp

["Till Rohrmann (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17011569#comment-17011569 ] 

Till Rohrmann edited comment on FLINK-15523 at 1/9/20 9:00 AM:
---------------------------------------------------------------

Due to FLIP-49, there are some breaking changes since some of the old options no longer have a respective counter part. This was intended and there will be a migration guide how to migrate from the old settings to the new settings. Consequently, I would not block the release on the removed {{TaskManager}} memory options. 

[~azagrebin], [~xintongsong] could you confirm that the memory related options were removed deliberately?

[~chesnay] is there a way to exclude certain options from the japicmp plugin check?


was (Author: till.rohrmann):
Due to FLIP-49, there are some breaking changes since some of the old options no longer have a respective counter part. This was intended and there will be a migration guide how to migrate from the old settings to the new settings. Consequently, I would not block the release on the removed {{TaskManager}} memory options. cc [~azagrebin], [~xintongsong].

> ConfigConstants generally excluded from japicmp
> -----------------------------------------------
>
>                 Key: FLINK-15523
>                 URL: https://issues.apache.org/jira/browse/FLINK-15523
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.8.0
>            Reporter: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.10.0
>
>
> It appears that {{ConfigConstants}}, despite being {{@Public}}, has been excluded from the japicmp check since {{1.5.0}}: [https://github.com/apache/flink/commit/1f9c2d9740ffea2b59b8f5f3da287a0dc890ddbf]
> This is a bit of a surprise to me and looks like a mistake (what's the point of excluding specific fields if the entire class is excluded), and if so this has repercussions on some ongoing work:
> {code:java}
> Breaking the build because there is at least one incompatibility: org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_SIZE_KEY:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_OFF_HEAP_KEY:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.DEFAULT_TASK_MANAGER_MEMORY_PRE_ALLOCATE:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_PRE_ALLOCATE_KEY:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_FRACTION_KEY:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.YARN_MAX_FAILED_CONTAINERS:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.DEFAULT_MEMORY_MANAGER_MEMORY_FRACTION:FIELD_REMOVED
>  {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)