[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #469: Override tag(AbstractTag, String) method in Entry Span

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #469:
URL: https://github.com/apache/skywalking-java/pull/469#discussion_r1125848600


##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/EntrySpan.java:
##########
@@ -61,6 +62,14 @@ public EntrySpan tag(String key, String value) {
         return this;
     }
 
+    @Override
+    public AbstractTracingSpan tag(AbstractTag<?> tag, String value) {
+        if (stackDepth == currentMaxDepth || tag.isCanOverwrite() || isInAsyncMode) {

Review Comment:
   super#tag includes `isCanOverwrite` already. I think we don't need it.
   
   `stackDepth == currentMaxDepth || isInAsyncMode` are the only required conditions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org