You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/04/02 23:33:37 UTC
[GitHub] [lucene-solr] ebehrendt opened a new pull request #1398:
SOLR-13101: Every BLOB_PULL_STARTED should have a matching
BLOB_PULL_FINISHED irrespective of failures
ebehrendt opened a new pull request #1398: SOLR-13101: Every BLOB_PULL_STARTED should have a matching BLOB_PULL_FINISHED irrespective of failures
URL: https://github.com/apache/lucene-solr/pull/1398
# Description
If exception is thrown during core pull from blob store, there is no record of the pull finishing. This caused a failure in SharedCoreConcurrencyTest.testIndexingQueriesDeletes() when it identified a BLOB_PULL_STARTED without a matching BLOB_PULL_FINISHED, meaning the pulls are interleaved. We want to record pull as finished upon completion even if it was unsuccessful.
# Solution
Move recording the state the pull as finished finally block so it will record pull as finished irrespective of failures.
# Tests
Reproduced failure by throwing an exception in pull code and verified that code change fixes the interleaved pull failure. Ran all tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1398:
SOLR-13101: Every BLOB_PULL_STARTED should have a matching
BLOB_PULL_FINISHED irrespective of failures
Posted by GitBox <gi...@apache.org>.
mbwaheed commented on a change in pull request #1398: SOLR-13101: Every BLOB_PULL_STARTED should have a matching BLOB_PULL_FINISHED irrespective of failures
URL: https://github.com/apache/lucene-solr/pull/1398#discussion_r404246925
##########
File path: solr/core/src/java/org/apache/solr/store/blob/process/CorePullTask.java
##########
@@ -354,10 +353,10 @@ void pullCoreFromBlob(boolean isLeaderPulling) throws InterruptedException {
}
}
}
+ concurrencyController.recordState(pullCoreInfo.getCollectionName(), pullCoreInfo.getShardName(), pullCoreInfo.getCoreName(), SharedCoreStage.BLOB_PULL_FINISHED);
Review comment:
This is meant to be matching BLOB_PULL_STARTED (line#248). At this place, depending on failures, it can be logged without BLOB_PULL_STARTED. You would need to put a new try after line#248 and a finally before line# 320. And then put this line inside that new finally.
Side note: This method needs some refactoring to simplify its flow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ebehrendt closed pull request #1398: SOLR-13101:
Every BLOB_PULL_STARTED should have a matching BLOB_PULL_FINISHED
irrespective of failures
Posted by GitBox <gi...@apache.org>.
ebehrendt closed pull request #1398: SOLR-13101: Every BLOB_PULL_STARTED should have a matching BLOB_PULL_FINISHED irrespective of failures
URL: https://github.com/apache/lucene-solr/pull/1398
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org