[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34453: [SPARK-37173][SQL] SparkGetFunctionOperation return builtin function only once

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #34453:
URL: https://github.com/apache/spark/pull/34453#discussion_r770259676



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1158,6 +1158,14 @@ object SQLConf {
     .intConf
     .createWithDefault(200)
 
+  val THRIFTSERVER_SEPARATE_DISPLAY_SYSTEM_FUNCTION =
+    buildConf("spark.sql.thriftserver.separateDisplaySystemFunctions")
+      .doc("When true, Spark Thrift Server will return databases' system functions metadata " +
+        "only once, and Spark will change function schema as `SYSTEM`.")

Review comment:
       > Does Apache Spark use `SYSTEM` before in other places?
   sessionCatalog.listFunctions()
   ```
       // so there can be duplicates.
       functions.map {
         case f if FunctionRegistry.functionSet.contains(f) => (f, "SYSTEM")
         case f if TableFunctionRegistry.functionSet.contains(f) => (f, "SYSTEM")
         case f => (f, "USER")
       }.distinct
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org