You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "watermelon12138 (via GitHub)" <gi...@apache.org> on 2023/03/28 13:02:51 UTC

[GitHub] [hudi] watermelon12138 opened a new pull request, #8308: [HUDI-5994] Bucket index supports bulk insert mode.

watermelon12138 opened a new pull request, #8308:
URL: https://github.com/apache/hudi/pull/8308

   ### Change Logs
   
   Bucket index supports bulk insert mode.
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] XuQianJin-Stars commented on a diff in pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "XuQianJin-Stars (via GitHub)" <gi...@apache.org>.
XuQianJin-Stars commented on code in PR #8308:
URL: https://github.com/apache/hudi/pull/8308#discussion_r1151327813


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestInsertTable.scala:
##########
@@ -1060,6 +1060,59 @@ class TestInsertTable extends HoodieSparkSqlTestBase {
     }
   }
 
+  test("Test Bulk Insert Into Bucket Index Table") {
+    withSQLConf("hoodie.sql.bulk.insert.enable" -> "true") {
+      withTempDir { tmp =>
+        val tableName = generateTableName
+        // Create a partitioned table
+        spark.sql(
+          s"""
+             |create table $tableName (
+             |  id int,
+             |  dt string,
+             |  name string,
+             |  price double,
+             |  ts long
+             |) using hudi
+             | tblproperties (
+             | primaryKey = 'id,name',
+             | preCombineField = 'ts',
+             | hoodie.index.type = 'BUCKET',
+             | hoodie.bucket.index.hash.field = 'id,name')
+             | partitioned by (dt)
+             | location '${tmp.getCanonicalPath}'
+       """.stripMargin)
+
+        // Note: Do not write the field alias, the partition field must be placed last.
+        spark.sql(
+          s"""
+             | insert into $tableName values
+             | (1, 'a1,1', 10, 1000, "2021-01-05"),

Review Comment:
   `a1,1` -> ` a1` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1489680835

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959) 
   * c930327ac667b95be444af5ca1e1e0500cf77cb7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] watermelon12138 commented on a diff in pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "watermelon12138 (via GitHub)" <gi...@apache.org>.
watermelon12138 commented on code in PR #8308:
URL: https://github.com/apache/hudi/pull/8308#discussion_r1152699437


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/BucketIdentifier.java:
##########
@@ -91,6 +91,10 @@ public static String newBucketFileIdPrefix(int bucketId) {
     return newBucketFileIdPrefix(bucketIdStr(bucketId));
   }
 
+  public static String newBucketFileIdPrefix(String fileId, int bucketId) {

Review Comment:
   No, newBucketFileIdPrefix(String fileId, int bucketId) function can make BulkInsertBucketInternalWriterHelper use the super function getNextFileId() of BulkInsertDataInternalWriterHelper. if we try to use the newBucketFileIdPrefix(String bucketId), we need to modify the getNextFileId() in BulkInsertDataInternalWriterHelper.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1493566371

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993",
       "triggerID" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003",
       "triggerID" : "1491165337",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16009",
       "triggerID" : "1491359307",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16010",
       "triggerID" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16071",
       "triggerID" : "1493541731",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9e617ccd64859b39980c3af6326f52ff2040436f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16074",
       "triggerID" : "9e617ccd64859b39980c3af6326f52ff2040436f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8e67e96e1d4afc8facf6155bae3ddcc4236d8282 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16010) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16071) 
   * 9e617ccd64859b39980c3af6326f52ff2040436f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16074) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1490411697

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993",
       "triggerID" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 77916c48361ac95d6fb4fafe01b91ff8eea87b07 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1491166397

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993",
       "triggerID" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003",
       "triggerID" : "1491165337",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 77916c48361ac95d6fb4fafe01b91ff8eea87b07 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1493559455

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993",
       "triggerID" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003",
       "triggerID" : "1491165337",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16009",
       "triggerID" : "1491359307",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16010",
       "triggerID" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16071",
       "triggerID" : "1493541731",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 8e67e96e1d4afc8facf6155bae3ddcc4236d8282 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16010) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16071) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] watermelon12138 commented on a diff in pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "watermelon12138 (via GitHub)" <gi...@apache.org>.
watermelon12138 commented on code in PR #8308:
URL: https://github.com/apache/hudi/pull/8308#discussion_r1152701320


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestInsertTable.scala:
##########
@@ -1060,6 +1060,59 @@ class TestInsertTable extends HoodieSparkSqlTestBase {
     }
   }
 
+  test("Test Bulk Insert Into Bucket Index Table") {
+    withSQLConf("hoodie.sql.bulk.insert.enable" -> "true") {
+      withTempDir { tmp =>
+        val tableName = generateTableName
+        // Create a partitioned table
+        spark.sql(
+          s"""
+             |create table $tableName (
+             |  id int,
+             |  dt string,
+             |  name string,
+             |  price double,
+             |  ts long
+             |) using hudi
+             | tblproperties (
+             | primaryKey = 'id,name',
+             | preCombineField = 'ts',
+             | hoodie.index.type = 'BUCKET',
+             | hoodie.bucket.index.hash.field = 'id,name')
+             | partitioned by (dt)
+             | location '${tmp.getCanonicalPath}'
+       """.stripMargin)
+
+        // Note: Do not write the field alias, the partition field must be placed last.
+        spark.sql(
+          s"""
+             | insert into $tableName values
+             | (1, 'a1,1', 10, 1000, "2021-01-05"),

Review Comment:
   This is to test the update, and I've modified the UT.



##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestInsertTable.scala:
##########
@@ -1060,6 +1060,59 @@ class TestInsertTable extends HoodieSparkSqlTestBase {
     }
   }
 
+  test("Test Bulk Insert Into Bucket Index Table") {
+    withSQLConf("hoodie.sql.bulk.insert.enable" -> "true") {
+      withTempDir { tmp =>
+        val tableName = generateTableName
+        // Create a partitioned table
+        spark.sql(
+          s"""
+             |create table $tableName (
+             |  id int,
+             |  dt string,
+             |  name string,
+             |  price double,
+             |  ts long
+             |) using hudi
+             | tblproperties (
+             | primaryKey = 'id,name',
+             | preCombineField = 'ts',
+             | hoodie.index.type = 'BUCKET',
+             | hoodie.bucket.index.hash.field = 'id,name')
+             | partitioned by (dt)
+             | location '${tmp.getCanonicalPath}'
+       """.stripMargin)
+
+        // Note: Do not write the field alias, the partition field must be placed last.
+        spark.sql(
+          s"""
+             | insert into $tableName values
+             | (1, 'a1,1', 10, 1000, "2021-01-05"),
+             | (2, 'a2', 20, 2000, "2021-01-06"),
+             | (3, 'a3', 30, 3000, "2021-01-07")
+              """.stripMargin)
+
+        checkAnswer(s"select id, name, price, ts, dt from $tableName")(
+          Seq(1, "a1,1", 10.0, 1000, "2021-01-05"),
+          Seq(2, "a2", 20.0, 2000, "2021-01-06"),
+          Seq(3, "a3", 30.0, 3000, "2021-01-07")
+        )
+
+        spark.sql(
+          s"""
+             | insert into $tableName values
+             | (1, 'a1,1', 10, 1000, "2021-01-05")

Review Comment:
   This is to test the update, and I've modified the UT.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 commented on pull request #8308: [HUDI-5994] Spark bulk insert with bucket index

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1537722512

   Reviewing now~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 commented on pull request #8308: [HUDI-5994] Spark bulk insert with bucket index

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1556628708

   Close and move the work to: https://github.com/apache/hudi/pull/8776


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] watermelon12138 commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "watermelon12138 (via GitHub)" <gi...@apache.org>.
watermelon12138 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1493541731

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] watermelon12138 commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "watermelon12138 (via GitHub)" <gi...@apache.org>.
watermelon12138 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1489757883

   @hudi-bot re-run the last Azure build


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 closed pull request #8308: [HUDI-5994] Spark bulk insert with bucket index

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 closed pull request #8308: [HUDI-5994] Spark bulk insert with bucket index
URL: https://github.com/apache/hudi/pull/8308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 commented on pull request #8308: [HUDI-5994] Spark bulk insert with bucket index

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1537895584

   Thanks for the contribution, I have reviewed and applied a patch:
   [5994.patch.zip](https://github.com/apache/hudi/files/11418924/5994.patch.zip)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1490077008

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c930327ac667b95be444af5ca1e1e0500cf77cb7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992) 
   * 77916c48361ac95d6fb4fafe01b91ff8eea87b07 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] XuQianJin-Stars commented on a diff in pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "XuQianJin-Stars (via GitHub)" <gi...@apache.org>.
XuQianJin-Stars commented on code in PR #8308:
URL: https://github.com/apache/hudi/pull/8308#discussion_r1151324017


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/BucketIdentifier.java:
##########
@@ -91,6 +91,10 @@ public static String newBucketFileIdPrefix(int bucketId) {
     return newBucketFileIdPrefix(bucketIdStr(bucketId));
   }
 
+  public static String newBucketFileIdPrefix(String fileId, int bucketId) {

Review Comment:
   This method is optimized with the other two methods `newBucketFileIdPrefix(int ​​bucketId)` and `newBucketFileIdPrefix(String bucketId)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] watermelon12138 commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "watermelon12138 (via GitHub)" <gi...@apache.org>.
watermelon12138 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1537680201

   @XuQianJin-Stars Can you review my code? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1490067966

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * c930327ac667b95be444af5ca1e1e0500cf77cb7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] watermelon12138 commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "watermelon12138 (via GitHub)" <gi...@apache.org>.
watermelon12138 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1490045887

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] chenbodeng719 commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "chenbodeng719 (via GitHub)" <gi...@apache.org>.
chenbodeng719 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1493555531

   @watermelon12138 Hi, https://github.com/apache/hudi/issues/8279, it seems that my issue is because of this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] watermelon12138 commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "watermelon12138 (via GitHub)" <gi...@apache.org>.
watermelon12138 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1491359307

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1490086421

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993",
       "triggerID" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c930327ac667b95be444af5ca1e1e0500cf77cb7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992) 
   * 77916c48361ac95d6fb4fafe01b91ff8eea87b07 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1489768727

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c930327ac667b95be444af5ca1e1e0500cf77cb7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1493562503

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993",
       "triggerID" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003",
       "triggerID" : "1491165337",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16009",
       "triggerID" : "1491359307",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16010",
       "triggerID" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16071",
       "triggerID" : "1493541731",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9e617ccd64859b39980c3af6326f52ff2040436f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9e617ccd64859b39980c3af6326f52ff2040436f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8e67e96e1d4afc8facf6155bae3ddcc4236d8282 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16010) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16071) 
   * 9e617ccd64859b39980c3af6326f52ff2040436f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1493704642

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993",
       "triggerID" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003",
       "triggerID" : "1491165337",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16009",
       "triggerID" : "1491359307",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16010",
       "triggerID" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16071",
       "triggerID" : "1493541731",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9e617ccd64859b39980c3af6326f52ff2040436f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16074",
       "triggerID" : "9e617ccd64859b39980c3af6326f52ff2040436f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9e617ccd64859b39980c3af6326f52ff2040436f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16074) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1491246786

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993",
       "triggerID" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003",
       "triggerID" : "1491165337",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 77916c48361ac95d6fb4fafe01b91ff8eea87b07 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] watermelon12138 commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "watermelon12138 (via GitHub)" <gi...@apache.org>.
watermelon12138 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1493736642

   @XuQianJin-Stars 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1487231525

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1489676522

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959) 
   * c930327ac667b95be444af5ca1e1e0500cf77cb7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1491398178

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993",
       "triggerID" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003",
       "triggerID" : "1491165337",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16009",
       "triggerID" : "1491359307",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16010",
       "triggerID" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 77916c48361ac95d6fb4fafe01b91ff8eea87b07 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16009) 
   * 8e67e96e1d4afc8facf6155bae3ddcc4236d8282 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16010) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1491392068

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993",
       "triggerID" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003",
       "triggerID" : "1491165337",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16009",
       "triggerID" : "1491359307",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 77916c48361ac95d6fb4fafe01b91ff8eea87b07 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16009) 
   * 8e67e96e1d4afc8facf6155bae3ddcc4236d8282 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] watermelon12138 commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "watermelon12138 (via GitHub)" <gi...@apache.org>.
watermelon12138 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1489760480

   @hudi-bot re-run


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] watermelon12138 commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "watermelon12138 (via GitHub)" <gi...@apache.org>.
watermelon12138 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1490033857

   @hudi-bot re-run


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1537719771

   Start reviewing now~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] XuQianJin-Stars commented on a diff in pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "XuQianJin-Stars (via GitHub)" <gi...@apache.org>.
XuQianJin-Stars commented on code in PR #8308:
URL: https://github.com/apache/hudi/pull/8308#discussion_r1151328221


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestInsertTable.scala:
##########
@@ -1060,6 +1060,59 @@ class TestInsertTable extends HoodieSparkSqlTestBase {
     }
   }
 
+  test("Test Bulk Insert Into Bucket Index Table") {
+    withSQLConf("hoodie.sql.bulk.insert.enable" -> "true") {
+      withTempDir { tmp =>
+        val tableName = generateTableName
+        // Create a partitioned table
+        spark.sql(
+          s"""
+             |create table $tableName (
+             |  id int,
+             |  dt string,
+             |  name string,
+             |  price double,
+             |  ts long
+             |) using hudi
+             | tblproperties (
+             | primaryKey = 'id,name',
+             | preCombineField = 'ts',
+             | hoodie.index.type = 'BUCKET',
+             | hoodie.bucket.index.hash.field = 'id,name')
+             | partitioned by (dt)
+             | location '${tmp.getCanonicalPath}'
+       """.stripMargin)
+
+        // Note: Do not write the field alias, the partition field must be placed last.
+        spark.sql(
+          s"""
+             | insert into $tableName values
+             | (1, 'a1,1', 10, 1000, "2021-01-05"),
+             | (2, 'a2', 20, 2000, "2021-01-06"),
+             | (3, 'a3', 30, 3000, "2021-01-07")
+              """.stripMargin)
+
+        checkAnswer(s"select id, name, price, ts, dt from $tableName")(
+          Seq(1, "a1,1", 10.0, 1000, "2021-01-05"),
+          Seq(2, "a2", 20.0, 2000, "2021-01-06"),
+          Seq(3, "a3", 30.0, 3000, "2021-01-07")
+        )
+
+        spark.sql(
+          s"""
+             | insert into $tableName values
+             | (1, 'a1,1', 10, 1000, "2021-01-05")

Review Comment:
   Is this sql insertion to verify the update?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1486912920

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1486897747

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] watermelon12138 commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "watermelon12138 (via GitHub)" <gi...@apache.org>.
watermelon12138 commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1491165337

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1491386213

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993",
       "triggerID" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003",
       "triggerID" : "1491165337",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16009",
       "triggerID" : "1491359307",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 77916c48361ac95d6fb4fafe01b91ff8eea87b07 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16009) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8308:
URL: https://github.com/apache/hudi/pull/8308#issuecomment-1491631512

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15959",
       "triggerID" : "50ad5161dcdb9cd651e4ccf69f8a95b7c8a6ee6e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15981",
       "triggerID" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c930327ac667b95be444af5ca1e1e0500cf77cb7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15992",
       "triggerID" : "1490045887",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15993",
       "triggerID" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "triggerType" : "PUSH"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16003",
       "triggerID" : "1491165337",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "77916c48361ac95d6fb4fafe01b91ff8eea87b07",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16009",
       "triggerID" : "1491359307",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16010",
       "triggerID" : "8e67e96e1d4afc8facf6155bae3ddcc4236d8282",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8e67e96e1d4afc8facf6155bae3ddcc4236d8282 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16010) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org